Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to Go version stanza to 1.18, bump hcl-lang to 1fce4f, terraform-schema to 0778c5 #1046

Merged
merged 5 commits into from
Aug 31, 2022
Merged

Bump to Go version stanza to 1.18, bump hcl-lang to 1fce4f, terraform-schema to 0778c5 #1046

merged 5 commits into from
Aug 31, 2022

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Aug 23, 2022

This PR updates the compatibility Go stanza to 1.18 and incorporates similar changes done in hashicorp/hcl-lang#129 and hashicorp/terraform-schema#134

Go 1.18 is required for the latest changes in go-cty 1.11.0

@dbanck dbanck added the dependencies Auto-pinning label Aug 23, 2022
@dbanck dbanck requested a review from a team as a code owner August 23, 2022 15:27
@dbanck dbanck changed the title Bump to Go version stanza to 1.18, bump hcl-lang, terraform-schema to latest Bump to Go version stanza to 1.18, bump hcl-lang to 1fce4f, terraform-schema to 3006b3 Aug 23, 2022
@dbanck dbanck changed the title Bump to Go version stanza to 1.18, bump hcl-lang to 1fce4f, terraform-schema to 3006b3 Bump to Go version stanza to 1.18, bump hcl-lang to 1fce4f, terraform-schema to 3006b3 Aug 23, 2022
radeksimko
radeksimko approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

Screenshot 2022-08-23 at 16 29 58

@dbanck dbanck changed the title Bump to Go version stanza to 1.18, bump hcl-lang to 1fce4f, terraform-schema to 3006b3 Bump to Go version stanza to 1.18, bump hcl-lang to 1fce4f, terraform-schema to 0778c5 Aug 31, 2022
@dbanck dbanck merged commit 48f0c68 into main Aug 31, 2022
@dbanck dbanck deleted the f-bump-go-118 branch August 31, 2022 16:06
@radeksimko radeksimko added this to the v0.29.2 milestone Sep 12, 2022
@github-actions
Copy link

This functionality has been released in v0.29.2 of the language server.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
dependencies Auto-pinning
Projects
None yet
Milestone
v0.29.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dbanck @radeksimko