Cache registry module errors #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors don't have a version, so we update the compound index to allow missing indices
radeksimko
approved these changes
Apr 26, 2023
| @@ -14,6 +14,7 @@ import ( | |||
| type RegistryModuleData struct { | |||
| Source tfaddr.Module | |||
| Version *version.Version | |||
| Error bool | |||
There was a problem hiding this comment.
Given that we only cache 404 errors, is it worth calling this e.g. NotFound or something similar instead of just Error?
There was a problem hiding this comment.
Since we now cache most 4XX errors, I'll keep it as is?
| @@ -67,3 +75,31 @@ func (s *RegistryModuleStore) Cache(sourceAddr tfaddr.Module, modVer *version.Ve | |||
| txn.Commit() | |||
| return nil | |||
| } | |||
|
|
|||
| func (s *RegistryModuleStore) CacheError(sourceAddr tfaddr.Module) error { | |||
There was a problem hiding this comment.
Similar question to above - should we call this e.g. CacheNotFound()?
jpogran
reviewed
Apr 26, 2023
radeksimko
approved these changes
Apr 27, 2023
Merged
This was referenced Apr 28, 2023
This was referenced May 2, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces caching for registry module HTTP request errors. We're currently only caching 404 errors, but it might also be sensible to cache other errors.
The change dramatically improves the performance when many jobs run in the background after a more significant text change.
UX
Before
After
