settings: Make root modules configurable #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-configurable-root-modules
branch
3 times, most recently
from
1b15cb6 to
b471876
Compare
radeksimko
commented
Jul 3, 2020
radeksimko
force-pushed
the
f-configurable-root-modules
branch
from
b471876 to
ce9337d
Compare
This comment has been minimized.
This comment has been minimized.
radeksimko
force-pushed
the
f-configurable-root-modules
branch
from
ce9337d to
8bd954d
Compare
This comment has been minimized.
This comment has been minimized.
radeksimko
force-pushed
the
f-configurable-root-modules
branch
from
8bd954d to
3805145
Compare
radeksimko
force-pushed
the
f-configurable-root-modules
branch
from
3805145 to
f183ba7
Compare
appilon
suggested changes
Jul 10, 2020
| @@ -198,3 +199,15 @@ func RootModuleWalker(ctx context.Context) (*rootmodule.Walker, error) { | |||
| } | |||
| return w, nil | |||
| } | |||
|
|
|||
| func WithRootModuleLoader(rml rootmodule.RootModuleLoader, ctx context.Context) context.Context { | |||
There was a problem hiding this comment.
Nit, make ctx first argument
There was a problem hiding this comment.
Yeah, I don't disagree, but I think I'd prefer to change all of the With* functions at the same time and perhaps do that in a separate PR, if that's ok and follow the same pattern throughout the package for now?
appilon
approved these changes
Jul 10, 2020
This was referenced Jul 10, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #196
Closes #189
Related: hashicorp/vscode-terraform#423