Improve root module discovery error handling #244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly improves logging, where previously we'd log error from plugin cache updating separately and then report 0 errors from loading a module, now all the loading stages are treated the same in terms of error reporting.
The relevant error is however still (intentionally) ignored as watcher invokes these methods:
terraform-ls/internal/watcher/watcher.go
Lines 89 to 94 in 2347f8d
Secondly this also improves the message we show when there is no root module found, to be more helpful until #222 is implemented and reflect that the message is related to the directory, rather than file.