-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vendoring #272
Remove vendoring #272
Conversation
@@ -8,6 +8,9 @@ on: | |||
branches: | |||
- master | |||
|
|||
env: | |||
GOPROXY: https://proxy.golang.org/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this not set by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default (according to go env
) is https://proxy.golang.org,direct
and so the idea here is that by excluding direct
we can effectively protect ourselves against the "leftpad situation" where the source would suddenly disappear by making sure that all dependencies are always cached before being added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one comment, also I wanted to inquire internally again to see if we have a proxy or not.
aa76116
to
0613e79
Compare
Sure, I'm happy to add it to the config once we confirm we have one, but I assume it's not a blocker. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This PR removes vendoring, as inspired by Terraform and motivated by the fact that
terraform-exec
currently depends ongo-getter
which in turn brings plenty of transitive dependencies, so this should make #271 much smaller.