Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendoring #272

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Remove vendoring #272

merged 1 commit into from
Oct 7, 2020

Conversation

radeksimko
Copy link
Member

This PR removes vendoring, as inspired by Terraform and motivated by the fact that terraform-exec currently depends on go-getter which in turn brings plenty of transitive dependencies, so this should make #271 much smaller.

@@ -8,6 +8,9 @@ on:
branches:
- master

env:
GOPROXY: https://proxy.golang.org/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not set by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default (according to go env) is https://proxy.golang.org,direct and so the idea here is that by excluding direct we can effectively protect ourselves against the "leftpad situation" where the source would suddenly disappear by making sure that all dependencies are always cached before being added.

Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment, also I wanted to inquire internally again to see if we have a proxy or not.

@radeksimko radeksimko force-pushed the no-vendor branch 2 times, most recently from aa76116 to 0613e79 Compare October 7, 2020 14:09
@radeksimko
Copy link
Member Author

I wanted to inquire internally again to see if we have a proxy or not.

Sure, I'm happy to add it to the config once we confirm we have one, but I assume it's not a blocker.

@radeksimko radeksimko merged commit 673548b into master Oct 7, 2020
@radeksimko radeksimko deleted the no-vendor branch October 7, 2020 14:18
@ghost
Copy link

ghost commented Nov 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants