Execute command support #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appilon
force-pushed
the
executeCommand
branch
from
8d91e4a to
aff4d2f
Compare
Reports rootmodules associated to passed file
appilon
force-pushed
the
executeCommand
branch
from
a178b53 to
a8e8c69
Compare
Implemented var=value style argument handling for executeCommand, and added version attribute to response for future flexibility. Improved diagnostic push error handling (don't panic on connection closed). Add test cases for command handlers.
appilon
commented
Oct 16, 2020
appilon
force-pushed
the
executeCommand
branch
2 times, most recently
from
53a4b6b to
5806e33
Compare
appilon
commented
Oct 19, 2020
radeksimko
reviewed
Oct 20, 2020
radeksimko
reviewed
Oct 21, 2020
appilon
force-pushed
the
executeCommand
branch
from
82727f3 to
075bb86
Compare
|
All comments addressed and tests passing, taking last review as approval |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for command execution (https://microsoft.github.io/language-server-protocol/specifications/specification-current/#workspace_executeCommand). First command is
rootmoduleswhich given a file uri reports if the walker is still walking and the root modules the file is associated to. Multiple rootmodule associations can occur if the file in focus is a module definition for multiple projects.This PR establishes some design for requests which should pass
"var=value"string arguments (prevent position from causing breaking changes), variables are case insensitive, values are interpreted asfloat64, thenbooland fallback tostring, they can be accessed by thecommandArgs.Get<Type>methods.Responses are a JSON object which is what the spec supports, they should have a
versionattribute starting at zero in case there is a need for breaking changes down the road.