Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for '$/cancelRequest' method #514

Merged
merged 1 commit into from
May 20, 2021
Merged

Conversation

radeksimko
Copy link
Member

Cancellation was fixed via #489

Here I'm just adding a test (which fails when concurrency is set to 1).

Closes #314

@radeksimko radeksimko added the bug Something isn't working label May 18, 2021
@radeksimko radeksimko requested a review from a team May 19, 2021 07:34
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko merged commit 29b3d95 into main May 20, 2021
@radeksimko radeksimko deleted the b-request-cancellation branch May 20, 2021 07:52
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix request cancellation
2 participants