refactor: Reflect upstream hcl-lang
changes
#689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on hashicorp/hcl-lang#92
This is to prepare for module enhancements as described in hashicorp/vscode-terraform#715
Closes #658
One other minor side effect of the refactoring is that we now highlight the
DefRange
(if available) of a definition instead of the wholeRange
. For example, when you click tovar.foobar
it takes you to the same location, butvariable "foobar"
is highlighted, instead of the wholevariable
block.In addition to decoder changes described already in the upstream PR there is a few more changes here.
context
package which makes the codebase more prone to import cycles and goes against best practices. The remaining necessary context-related logic is broken down into the packages which produce the relevant data.ModuleManager