Remove go-getter & simplify module source detection #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-remove-go-getter
branch
from
0651fad to
2432058
Compare
radeksimko
force-pushed
the
f-remove-go-getter
branch
2 times, most recently
from
e7f95d0 to
70a7692
Compare
radeksimko
force-pushed
the
f-remove-go-getter
branch
from
70a7692 to
786d158
Compare
radeksimko
changed the title
jpogran
reviewed
Feb 25, 2022
Comment on lines
+19
to
+25
| var moduleSourceLocalPrefixes = []string{ | ||
| "./", | ||
| "../", | ||
| ".\\", | ||
| "..\\", | ||
| } | ||
|
|
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the relatively non-critical part of code which is responsible for detecting module source (which has the effect of displaying different icons in the UI).
Here I'm trading-off possibly less accuracy for faster compile times by removing go-getter as a dependency.
In GitHub CI, the cross-compilation was previously around 8-11mins:
This should shave off at least a few minutes on average - the CI run associated with this PR reported
5m 33s.