Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goreleaser: Enable pre-release publishing #798

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Feb 22, 2022

TODO:

  • Verify impact on https://github.com/hashicorp/vscode-terraform (earlier versions which do not bundle LS)
  • Docs to cover expectations of pre-releases and how to obtain them
  • Linux packages - do other product publish them for pre-releases? Do we need to do anything extra?

Closes #456

See relevant docs at https://goreleaser.com/customization/release/#github

  # If set to auto, will mark the release as not ready for production
  # in case there is an indicator for this in the tag e.g. v1.0.0-rc1
  # If set to true, will mark the release as not ready for production.
  # Default is false.
  prerelease: auto

and https://goreleaser.com/customization/homebrew/

    # If set to auto, the release will not be uploaded to the homebrew tap
    # in case there is an indicator for prerelease in the tag e.g. v1.0.0-rc1
    # Default is false.
    skip_upload: true

@radeksimko radeksimko added the ci Continuous integration/delivery related label Feb 22, 2022
@radeksimko radeksimko marked this pull request as ready for review February 22, 2022 16:37
@jpogran
Copy link
Contributor

jpogran commented Feb 22, 2022

We specify latest by default using https://github.com/hashicorp/vscode-terraform/blob/ddddaf39c5970266a2d5ea21c75e573e31cb5152/src/installer/updater.ts#L36. DEFAULT_LS_VERSION is defined at https://github.com/hashicorp/vscode-terraform/blob/v2.19.0/src/installer/detector.ts#L6. This means the default action is to download only the latest stable version.

I verified this by setting up a test repo with the methods we use and pointed it to the terraform project which produces pre-release versions.

A user would have to manually specify a pre-release version using the deprecated terraform.languageServer.requiredVersion to purposely download a pre-release version.

@radeksimko radeksimko requested a review from a team February 22, 2022 18:16
@radeksimko
Copy link
Member Author

I will cover docs update in a separate PR and I confirmed that Linux packaging for pre-releases is handled and we don't need to do anything extra for that.

@radeksimko radeksimko merged commit 5380875 into main Feb 24, 2022
@radeksimko radeksimko deleted the ci-goreleaser-skip-brew-upload branch February 24, 2022 17:14
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid publishing pre-releases to Homebrew tap
2 participants