fix: decode all submodules with the right path #810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #801
Prior to this patch we would only decode the last submodule in the slice. This was because of a common mistake documented in https://github.com/golang/go/wiki/CommonMistakes#using-reference-to-loop-iterator-variable
i.e. we were passing a reference to the job functions which were executed well after the ranging over the slice was done, hence reusing the same reference, with the reference pointing to the last value in the last iteration.
I believe this was only introduced in the refactoring PR #782 so if we patch it prior to the next release there would be no user affected.
Attached below is the same example as in the original bug report, now working: