Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: adjust min & max for benchmarks #888

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Conversation

radeksimko
Copy link
Member

This is to address the following benchmark threshold failures:

{ "Status": "fail", "Diffs": [ { "Status": "fail", "Package": "github.com/hashicorp/terraform-ls/internal/langserver/handlers", "Benchmark": "BenchmarkInitializeFolder_basic/aws-eks-2", "Value": 2942.189635 } ], "Thresholds": { "Min": 1570, "Max": 2900 } }
{ "Status": "fail", "Diffs": [ { "Status": "fail", "Package": "github.com/hashicorp/terraform-ls/internal/langserver/handlers", "Benchmark": "BenchmarkInitializeFolder_basic/local-single-module-random-2", "Value": 171.50729 } ], "Thresholds": { "Min": 180, "Max": 300 } }
{ "Status": "fail", "Diffs": [ { "Status": "fail", "Package": "github.com/hashicorp/terraform-ls/internal/langserver/handlers", "Benchmark": "BenchmarkInitializeFolder_basic/local-single-submodule-no-provider-2", "Value": 174.706908 } ], "Thresholds": { "Min": 185, "Max": 310 } }

@radeksimko radeksimko added the ci Continuous integration/delivery related label Apr 25, 2022
@radeksimko radeksimko requested a review from a team as a code owner April 25, 2022 08:01
@radeksimko radeksimko merged commit c124092 into main Apr 25, 2022
@radeksimko radeksimko deleted the ci-adjust-benchmarks branch April 25, 2022 08:37
@radeksimko radeksimko added this to the v0.28.0 milestone May 20, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants