Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handlers/command: Return partially parsed metadata from module.providers #951

Merged
merged 1 commit into from
Jun 14, 2022
Merged

handlers/command: Return partially parsed metadata from module.providers #951

merged 1 commit into from
Jun 14, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jun 14, 2022 •
edited
Loading

Fixes #906

Before

Screenshot 2022-06-14 at 09 52 23

After

Screenshot 2022-06-14 at 09 51 22

@radeksimko radeksimko added the bug Something isn't working label Jun 14, 2022
@radeksimko radeksimko added this to the v0.28.2 milestone Jun 14, 2022
@radeksimko radeksimko requested a review from a team as a code owner June 14, 2022 08:53
@radeksimko radeksimko changed the title handlers/command: Return partially parsed metadata from module.providers handlers/command: Return partially parsed metadata from module.providers Jun 14, 2022
jpogran
jpogran approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@radeksimko radeksimko merged commit b0dbd1a into main Jun 14, 2022
@radeksimko radeksimko deleted the fix-module-providers branch June 14, 2022 13:33
@radeksimko radeksimko modified the milestones: v0.28.2, v0.29.0 Jun 17, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpogran jpogran jpogran approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.29.0
Development

Successfully merging this pull request may close these issues.

module.providers returns no providers when required_providers has incomplete address
2 participants
@radeksimko @jpogran