Support 'offline mode': do not download terraform binary

[GennadySpb]

Signed-off-by: Gennady Lipenkov xgen@yandex-team.ru

[GennadySpb]

@bflad Please check this PR)

[bflad]

Hi @GennadySpb 👋 Thank you for submitting this. As discussed in #77 (which I think we should give @syndicut an opportunity to adjust/submit first), I think an ideal implementation here would be to unilaterally check for a Terraform binary first, then fall back to downloading the latest version. If folks desire a way to use an exact binary, we can provide a separate flag or environment variable.

[bflad]

Recommend switching this to checkpoint.LatestVersion, instead of keeping the hardcoded Terraform version.

[GennadySpb]

Hi @GennadySpb 👋 Thank you for submitting this. As discussed in #77 (which I think we should give @syndicut an opportunity to adjust/submit first), I think an ideal implementation here would be to unilaterally check for a Terraform binary first, then fall back to downloading the latest version. If folks desire a way to use an exact binary, we can provide a separate flag or environment variable.

So, make refactor to implement described behavior. Also support set exact Terraform version by arg -tf-version to download.

[bflad]

Thanks for the update, @GennadySpb 👍 We'll see if @syndicut responds in the next week or so and if not, we can move forward with something like this.

[bflad]

Some minor things, otherwise looking good to me.

[syndicut]

Thanks for the update, @GennadySpb 👍 We'll see if @syndicut responds in the next week or so and if not, we can move forward with something like this.

I don't mind merging @GennadySpb's PR instead of mine

[GennadySpb]

@bflad accept all your changes ;)

[bflad]

Looks good to me, thank you @GennadySpb 🚀 Verified using terraform-provider-scaffolding:

$ go mod edit -replace=github.com/hashicorp/terraform-plugin-docs=/Users/bflad/src/github.com/hashicorp/terraform-plugin-docs
$ go mod tidy
$ go generate ./...
rendering website for provider "terraform-provider-scaffolding"
exporting schema from Terraform
compiling provider "scaffolding"
using Terraform CLI binary from PATH if available, otherwise downloading latest Terraform CLI binary
running terraform init
getting provider schema
rendering missing docs
generating missing resource content
generating template for "scaffolding_resource"
generating missing data source content
generating template for "scaffolding_data_source"
generating missing provider content
generating template for "terraform-provider-scaffolding"
rendering static website
cleaning rendered website dir
rendering templated website to static markdown
rendering "data-sources/data_source.md.tmpl"
rendering "index.md.tmpl"
rendering "resources/resource.md.tmpl"

So nice saving the download time each execution. 😄

[GennadySpb]

@bflad what about tests? I see some failed.

[GennadySpb]

@bflad what about tests? I see some failed.

Check PR - contains fix :)

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.