Conflicting Multiple Attribute Validation (ConflictsWith / ConflictingAttributes)

[bflad]

Terraform CLI and Framework Versions

Any Terraform CLI version; terraform-plugin-framework v0.8.0

Use Cases or Problem Statement

Provider developers should be able to generically validate that a set of attributes should all contain null configuration values, if a certain attribute has a non-null configuration value.

Proposal

These are not necessarily mutually exclusive proposals -- both types of implementations have been requested in the past.

Proposal 1 (AttributeValidator Style)

This would be similar to the helper/schema.Schema.ConflictsWith field implementation.

Inside a multivalidator package, create a new unexported type that satisfies the tfsdk.AttributeValidator interface:

var _ conflictsWithValidator = tfsdk.AttributeValidator

type conflictsWithValidator struct {
  attributePaths []AttributePath
}

func (v conflictsWithValidator) Description(ctx context.Context) string {/*...*/}
func (v conflictsWithValidator) MarkdownDescription(ctx context.Context) string {/*...*/}
func (v conflictsWithValidator) Validate(ctx context.Context, req tfsdk.ValidateAttributeRequest, resp *tfsdk.ValidateAttributeResponse) {/*...*/}

Then, create an exported function that returns it:

func ConflictsWith(attributePaths AttributePath...) AttributeValidator {/*...*/}

This would allow provider developers to declare attributes such as:

tfsdk.Attribute{
  // ... other fields ...
  Type: types.String{},
  Validators: tfsdk.AttributeValidators{
    multivalidator.ConflictsWith(
      tftypes.NewAttributePath().WithAttributeName("other"), // until attribute paths/matchers are native
    ),
  },
},

Proposal 2 (ConfigValidator Style)

Rather than being part of the schema, this would enable provider developers to create it at the top level of a resource, etc.

Inside a configvalidator package, create a new unexported type that satisfies the tfsdk.ResourceConfigValidator interface (allowing a configuration validator across data sources, providers, and resources would require an upstream breaking change to those interfaces):

var _ conflictingAttributesValidator = tfsdk.ResourceConfigValidator

type conflictingAttributesValidator struct {
  attributePaths []AttributePath
}

func (v conflictingAttributesValidator) Description(ctx context.Context) string {/*...*/}
func (v conflictingAttributesValidator) MarkdownDescription(ctx context.Context) string {/*...*/}
func (v conflictingAttributesValidator) Validate(ctx context.Context, req tfsdk.ResourceConfigValidatorRequest, resp *tfsdk.ResourceConfigValidatorResponse) {/*...*/}

Then, create an exported function that returns it:

func ConflictingAttributes(attributePaths AttributePath...) AttributeValidator {/*...*/}

This would allow provider developers to declare resources such as:

var _ tfsdk.ResourceWithConfigValidators = exampleResource{}

func (r exampleResource) ConfigValidators(ctx context.Context) []tfsdk.ResourceConfigValidator {
  return []tfsdk.ResourceConfigValidator{
    configvalidator.ConflictingAttributes(
      // attribute path 1
      // attribute path 2
    ),
  },
}

Additional Information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.