Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double quoting in string validator descriptions #152

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett commented Aug 1, 2023

Closes: #149

Usage of fmt.Sprintf("......%q") has been checked throughout and does not appear to be an issue except in the cases in the stringvalidator package that are fixed in this PR.

@bendbennett bendbennett marked this pull request as ready for review August 1, 2023 09:50
@bendbennett bendbennett requested a review from a team as a code owner August 1, 2023 09:50
@bendbennett bendbennett added the bug Something isn't working label Aug 1, 2023
@bendbennett bendbennett added this to the v0.11.0 milestone Aug 1, 2023
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@bendbennett bendbennett merged commit c3ae185 into main Aug 3, 2023
@bendbennett bendbennett deleted the bendbennett/issues-149 branch August 3, 2023 06:15
@mgwoj
Copy link

mgwoj commented Aug 3, 2023

Thank you for fixing this issue. Do you have any estimate for the release date?

@bendbennett
Copy link
Contributor Author

@mgwoj this bug fix has been released along with some other changes as part of the v0.11.0 release.

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stringvalidator.OneOf is producing incorrectly escaped string
3 participants