-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add All
, Any
, and AnyWithAllWarnings
validators to boolvalidator
, providervalidator
, resourcevalidator
and datasourcevalidator
packages
#158
Conversation
…alidator` package
…idator` package
…idator` package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor example fix, otherwise looks good to me 🚀
Co-authored-by: Brian Flad <bflad417@gmail.com>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes: #122
This PR adds
All
,Any
, andAnyWithAllWarnings
validators to theboolvalidator
,providervalidator
,resourcevalidator
anddatasourcevalidator
packages to bring it in parity with the other validator packages. There are associated tests for all validators except for the ones in theboolvalidator
package because of the complexities of test design for these particular tests. However, the logic used in these validators are the same across all corresponding validator packages, therefore the logic is already well tested.