-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: Add support for unknown value refinement data to all types #1062
Draft
austinvalle
wants to merge
41
commits into
main
Choose a base branch
from
av/refinements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11,933
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvalle
added
enhancement
New feature or request
types
Issues and pull requests about our types abstraction and implementations.
labels
Dec 3, 2024
austinvalle
commented
Dec 4, 2024
@@ -6,7 +6,7 @@ toolchain go1.22.7 | |||
|
|||
require ( | |||
github.com/google/go-cmp v0.6.0 | |||
github.com/hashicorp/terraform-plugin-go v0.25.0 | |||
github.com/hashicorp/terraform-plugin-go v0.25.1-0.20241126200214-bd716fcfe407 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: update with released version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
types
Issues and pull requests about our types abstraction and implementations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #869
Ref: hashicorp/terraform#30937
Ref: hashicorp/terraform-plugin-go#448
This PR introduces value refinement support to the
basetypes
Go package, which allows Framework providers to communicate unknown value refinements to/from Terraform core (first introduced in Terraform 1.6).Value refinements are additional constraints that can be applied to unknown values in Terraform that can be used to produce known results from unknown values. For example, with value refinements, providers can now indicate specific attributes will "definitely not be null" during
PlanResourceChange
, which would allow Terraform core to successfully evaluate expressions like count during plan:Without unknown value refinements, the above config will return an error when running
terraform plan
:TODOs left on this PR
Dynamic
paths with refinements. There shouldn't be any changes needed since it's just a container (and dynamic itself cannot have a refinement)terraform-plugin-go
, once that's ready