schema: Proof of concept Schema and Attribute validation #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added a commit
that referenced
this pull request
Jul 20, 2021
Reference: #76 This is now stuck at the below: ``` package github.com/hashicorp/terraform-plugin-framework/internal/proto6 imports github.com/hashicorp/terraform-plugin-framework/tfsdk imports github.com/hashicorp/terraform-plugin-framework/internal/proto6: import cycle not allowed ```
bflad
added a commit
that referenced
this pull request
Jul 20, 2021
Reference: #76 This is now stuck at the below: ``` package github.com/hashicorp/terraform-plugin-framework/internal/proto6 imports github.com/hashicorp/terraform-plugin-framework/tfsdk imports github.com/hashicorp/terraform-plugin-framework/internal/proto6: import cycle not allowed ```
bflad
added a commit
that referenced
this pull request
Jul 20, 2021
Reference: #76 These types are tightly coupled to Schema and Attribute handling and migrating them will allow for future enhancements with Attribute plan modifications and validations to reference these types without an import cycle.
bflad
added a commit
that referenced
this pull request
Jul 27, 2021
Reference: #76 This is now stuck at the below: ``` package github.com/hashicorp/terraform-plugin-framework/internal/proto6 imports github.com/hashicorp/terraform-plugin-framework/tfsdk imports github.com/hashicorp/terraform-plugin-framework/internal/proto6: import cycle not allowed ```
bflad
added a commit
that referenced
this pull request
Jul 27, 2021
Reference: #76 These types are tightly coupled to Schema and Attribute handling and migrating them will allow for future enhancements with Attribute plan modifications and validations to reference these types without an import cycle.
bflad
added a commit
that referenced
this pull request
Jul 29, 2021
…k package (#77) * Migrate schema package into tfsdk package Reference: #76 This is now stuck at the below: ``` package github.com/hashicorp/terraform-plugin-framework/internal/proto6 imports github.com/hashicorp/terraform-plugin-framework/tfsdk imports github.com/hashicorp/terraform-plugin-framework/internal/proto6: import cycle not allowed ``` * Migrate internal/proto6 Schema and Attribute functions to unexported tfsdk receiver methods * Add CHANGELOG for #77
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #17
Reference: #65
Note that this code as written introduces an import cycle between tfsdk and schema packages as they need to cross-reference types. Proposal pull requests will be submitted to migrate certain package functionality between packages to alleviate the issue.