tftypes: Return null Number when NewValue receives (*big.Float)(nil) (#…

…114) Reference: hashicorp/terraform-plugin-framework#89 This matches the consistency of other pointer types in the `valueFromNumber` function and can prevent unexpected panics.
hashicorp · Oct 5, 2021 · fee1e53 · fee1e53
1 parent 990b525
commit fee1e53
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/.changelog/pending.txt b/.changelog/pending.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+tftypes: Return null `Number` when `NewValue` receives `(*big.Float)(nil)`
+```
diff --git a/tftypes/primitive.go b/tftypes/primitive.go
@@ -156,6 +156,12 @@ func valueFromBool(in interface{}) (Value, error) {
 func valueFromNumber(in interface{}) (Value, error) {
 	switch value := in.(type) {
 	case *big.Float:
+		if value == nil {
+			return Value{
+				typ:   Number,
+				value: nil,
+			}, nil
+		}
 		return Value{
 			typ:   Number,
 			value: value,

diff --git a/tftypes/value_number_test.go b/tftypes/value_number_test.go
@@ -89,6 +89,10 @@ func TestNewValue_number(t *testing.T) {
 			expected: Value{typ: Number, value: nil},
 			result:   NewValue(Number, nil),
 		},
+		"*big.Float-nil": {
+			expected: Value{typ: Number, value: nil},
+			result:   NewValue(Number, (*big.Float)(nil)),
+		},
 		"*big.Float": {
 			expected: Value{typ: Number, value: big.NewFloat(123)},
 			result:   NewValue(Number, big.NewFloat(123)),