Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new package,
tfprotov6
. It is mostly copy-pasted fromtfprotov5
. The interesting changes (besides just swapping 5 for 6 in imports everywhere) is the newtfprotov6/internal/tfplugin6/tfplugin6.proto
file, taken directly from terraform's main branch, an assortment of renamed functions (ValidateResourceTypeConfig
is nowValidateResourceConfig
, etc - all the changes we discussed internally), and finally the interesting one, the newNestedType
field inside anAttribute
(with associated conversions in toproto and fromproto).If you want to see any of this in action, I have a very tiny implementation of the random provider with this branch vendored: https://github.com/mildwonkey/terraform-provider-random
I also have a fork of ptyng's sql provider using this; it works as a provider just fine but I'm still struggling with the acceptance tests, which required changes to the sdkv2. I'll keep poking at that; it'd be nice to show off a provider using these new features with working tests.