Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust function signature of NewMuxServer in tf5muxserver/tf6muxserver to return *muxServer #172

Closed
bendbennett opened this issue Jun 29, 2023 · 1 comment · Fixed by #173
Closed

Adjust function signature of NewMuxServer in tf5muxserver/tf6muxserver to return *muxServer #172

bendbennett opened this issue Jun 29, 2023 · 1 comment · Fixed by #173
Labels
bug Something isn't working
Milestone
v0.11.1

Comments

@bendbennett
Copy link
Contributor

terraform-plugin-mux version

v0.11.0

Relevant provider source code

N/A

Terraform Configuration Files

N/A

Expected Behavior

The NewMuxServer() func should in the tf5muxserver and tf6muxserver packages should return a pointer to muxServer.

Actual Behavior

The NewMuxServer() func in the tf5muxserver and tf6muxserver packages returns a reference to muxServer.

Steps to Reproduce

N/A

References
@bendbennett bendbennett added the bug Something isn't working label Jun 29, 2023
@bendbennett bendbennett added this to the v0.11.1 milestone Jun 29, 2023
bendbennett added a commit that referenced this issue Jun 29, 2023
@bendbennett
Adjust function signature of NewMuxServer in tf5muxserver/tf6muxserve…
2c70f63 
…r to return *muxServer (#172)
@bendbennett bendbennett mentioned this issue Jun 29, 2023
Merged
bendbennett added a commit that referenced this issue Jun 29, 2023
@bendbennett @bflad
Adjust function signature of NewMuxServer in tf5muxserver/tf6muxserve…
052a907 
…r to return *muxServer (#173)

* Adjust function signature of NewMuxServer in tf5muxserver/tf6muxserver to return *muxServer (#172)

* Apply suggestions from code review

Co-authored-by: Brian Flad <bflad417@gmail.com>

---------

Co-authored-by: Brian Flad <bflad417@gmail.com>
@github-actions GitHub Actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.11.1
1 participant
@bendbennett