Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ConfigureProvider Response Diagnostics are Unit Tested #178

Closed
bflad opened this issue Jul 13, 2023 · 1 comment · Fixed by #179
Closed

Ensure ConfigureProvider Response Diagnostics are Unit Tested #178

bflad opened this issue Jul 13, 2023 · 1 comment · Fixed by #179
Assignees
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Jul 13, 2023

terraform-plugin-mux version

v0.11.1

Use cases

The tf5muxserver and tf6muxserver implementations of ConfigureProvider RPC includes logic which handles diagnostics from the underlying servers.

Proposal

Implement additional unit testing for that RPC, similar to #177. The TestServer implementation can be updated to include additional response fields:

type TestServer struct {
  // ...
  ConfigureProviderResponse *tfprotov5.ConfigureProviderResponse
}

And additional RPC tests can be added to ensure those underlying server diagnostics are correctly in the final response.

Bonus: While in the area, it might be good to update StopProviderError to StopProviderResponse instead for consistency.

@bflad bflad changed the title Ensure ConfigureProvider and StopProvider Response Error/Diagnostics are Unit Tested Ensure ConfigureProvider Response Diagnostics are Unit Tested Jul 14, 2023
bflad added a commit that referenced this issue Jul 14, 2023
…nd StopProvider response diagnostics/errors

Reference: #178
@bflad bflad self-assigned this Jul 14, 2023
@bflad bflad added this to the v0.11.2 milestone Jul 14, 2023
bflad added a commit that referenced this issue Jul 14, 2023
…nd StopProvider response diagnostics/errors (#179)

Reference: #178
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant