Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tf5muxserver+tf6muxserver: Support GetProviderSchema response ServerCapabilities #133

Merged
merged 5 commits into from
Feb 8, 2023
Merged

tf5muxserver+tf6muxserver: Support GetProviderSchema response ServerCapabilities #133

merged 5 commits into from
Feb 8, 2023

Commits on Feb 7, 2023

  1. tf5muxserver+tf6muxserver: Support GetProviderSchema response ServerC… 

    …apabilities

Reference: #131

First, this enables the mux servers to capture and handle underlying `GetProviderSchema` RPC response `ServerCapabilities`. The first capability supported is `PlanDestroy`, which in Terraform 1.3+ will trigger Terraform to send the `PlanResourceChange` RPC to the provider during resource destroy. Any server capabilities enabled across the underlying servers use a logical OR to form the single mux server response.

Enabling the RPC in that scenario unexpectedly for providers could cause either SDK or provider errors and panics. While the mux server will unilaterally enable the behavior for any resource type by nature of the single boolean field across the protocol, it will attempt to filter `PlanResourceChange` calls based on whether the underlying server signaled the capability. If determined to be a destroy plan and the server does not enable the capability, the mux server will send its own response without calling the underlying server.
    @bflad
    bflad committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    d5ca073 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG for #133

    @bflad
    bflad committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    cd306ca View commit details
    Browse the repository at this point in the history

  3. tf6muxserver: Add missing serverCapabilities instantiation

    @bflad
    bflad committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    06c85db View commit details
    Browse the repository at this point in the history

  4. tf5muxserver+tf6muxserver: Always send ServerCapabilities.PlanDestroy

    @bflad
    bflad committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    84c11f9 View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG for #133

    @bflad
    bflad committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    21212aa View commit details
    Browse the repository at this point in the history