Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more permissive when checking schemas are identical. #18

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Be more permissive when checking schemas are identical. #18

merged 2 commits into from
Feb 10, 2021

Commits on Jan 4, 2021

  1. Be more permissive when checking schemas are identical. 

    Allow schemas to differ in the order of attributes if they are otherwise
identical. Applies to the checks on provider schemas and provider_meta
schemas to ensure the servers are in agreement.
    @paddycarver
    paddycarver committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    44fd9b8 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Another pass at more lenient schema checks. 

    Make sure that schemas are compared semantically, by not caring about
the order of blocks or attributes in the results for Provider and
ProviderMeta.

Add tests to verify that this is the case.

When Provider or ProviderMeta schemas don't match, include the diff in
the error for easier debugging.
    @paddycarver
    paddycarver committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    6c12ef6 View commit details
    Browse the repository at this point in the history