Complex ExpectError handling functions

[obourdon]

See the following links for details:

• ExpectError supports for Regexp is not sufficient in some cases #1014
• Early fatal ASG errors are only reported after complete resource retrial timeout terraform-provider-aws#25986
• Fix for ASG early errors issue terraform-provider-aws#25987

The documentation has been also updated to include meaningful example for this new functionnality

[bflad]

Hi @obourdon 👋 Thank you for submitting this.

In general, our preference for field types should always be to make them more type constrained, rather than less. Consumers encountering fields that accept any/interface{} are left without Go compiler help for their implementations and the additional burden to fully understand the implementation details of the underlying functionality by reading into the Go or website documentation further.

In this case, if we were to do anything here, the preference would be to create a new ErrorCheck func(error) error field at the TestStep level which mimics the existing behavior at the TestCase level. We'll also need to ensure there is covering unit testing of the expected behaviors. The testing framework validation logic can be augmented to raise an error if both ExpectError and ErrorCheck are defined in the same TestStep. If you're interested in that type of implementation, then let's discuss that further in the open issue or in a new pull request.

Thanks again.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.