remove resource.TestT

[appilon]

The interface and associated tests are not useful for V2

[paultyng]

I think you may want to keep this so you don't need to import the testing package in live code?

[appilon]

Probably, except we currently do in RunNewTest which probably was an oversight in V1 (so testing is exposed in the V1 API as it is). We type asserted to testing.T to satisfy a testing interface in terraform-plugin-test https://github.com/hashicorp/terraform-plugin-test/blob/master/guard.go#L79.

We will have to harmonize the interfaces if we don't want to directly import testing in V2

[paultyng]

We should probably just push them all to https://github.com/mitchellh/go-testing-interface ? Not sure, would maybe want to ask internally if there is a consensus here.

[appilon]

@paultyng We should make them both the same I like that idea but then we are exposing an interface owned by mitchell to the surface. I can try type asserting to terraform-plugin-test's interface and seeing if that works (then testing.T appears nowhere).

[appilon]

#396 opts to simulate fatal on mockT with panic/recover, cherry-picking that to V2 will remove the need for this PR.

cleaning up the interface usage and casting in V2 can be done in another PR

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.