Adding return statements (#266)

hashicorp · Jan 22, 2024 · 518c94c · 518c94c
1 parent c542a70
commit 518c94c
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 0 deletions.
diff --git a/statecheck/expect_known_output_value.go b/statecheck/expect_known_output_value.go
@@ -27,10 +27,14 @@ func (e expectKnownOutputValue) CheckState(ctx context.Context, req CheckStateRe
 
 	if req.State == nil {
 		resp.Error = fmt.Errorf("state is nil")
+
+		return
 	}
 
 	if req.State.Values == nil {
 		resp.Error = fmt.Errorf("state does not contain any state values")
+
+		return
 	}
 
 	for address, oc := range req.State.Values.Outputs {

diff --git a/statecheck/expect_known_output_value_at_path.go b/statecheck/expect_known_output_value_at_path.go
@@ -28,10 +28,14 @@ func (e expectKnownOutputValueAtPath) CheckState(ctx context.Context, req CheckS
 
 	if req.State == nil {
 		resp.Error = fmt.Errorf("state is nil")
+
+		return
 	}
 
 	if req.State.Values == nil {
 		resp.Error = fmt.Errorf("state does not contain any state values")
+
+		return
 	}
 
 	for address, oc := range req.State.Values.Outputs {

diff --git a/statecheck/expect_known_value.go b/statecheck/expect_known_value.go
@@ -28,14 +28,20 @@ func (e expectKnownValue) CheckState(ctx context.Context, req CheckStateRequest,
 
 	if req.State == nil {
 		resp.Error = fmt.Errorf("state is nil")
+
+		return
 	}
 
 	if req.State.Values == nil {
 		resp.Error = fmt.Errorf("state does not contain any state values")
+
+		return
 	}
 
 	if req.State.Values.RootModule == nil {
 		resp.Error = fmt.Errorf("state does not contain a root module")
+
+		return
 	}
 
 	for _, resourceChange := range req.State.Values.RootModule.Resources {
@@ -62,6 +68,8 @@ func (e expectKnownValue) CheckState(ctx context.Context, req CheckStateRequest,
 
 	if err := e.knownValue.CheckValue(result); err != nil {
 		resp.Error = fmt.Errorf("error checking value for attribute at path: %s.%s, err: %s", e.resourceAddress, e.attributePath.String(), err)
+
+		return
 	}
 }
 

diff --git a/statecheck/expect_sensitive_value.go b/statecheck/expect_sensitive_value.go
@@ -26,14 +26,20 @@ func (e expectSensitiveValue) CheckState(ctx context.Context, req CheckStateRequ
 
 	if req.State == nil {
 		resp.Error = fmt.Errorf("state is nil")
+
+		return
 	}
 
 	if req.State.Values == nil {
 		resp.Error = fmt.Errorf("state does not contain any state values")
+
+		return
 	}
 
 	if req.State.Values.RootModule == nil {
 		resp.Error = fmt.Errorf("state does not contain a root module")
+
+		return
 	}
 
 	for _, resourceChange := range req.State.Values.RootModule.Resources {
@@ -71,11 +77,13 @@ func (e expectSensitiveValue) CheckState(ctx context.Context, req CheckStateRequ
 	isSensitive, ok := result.(bool)
 	if !ok {
 		resp.Error = fmt.Errorf("invalid path: the path value cannot be asserted as bool")
+
 		return
 	}
 
 	if !isSensitive {
 		resp.Error = fmt.Errorf("attribute at path is not sensitive")
+
 		return
 	}
 }