Additional comments for Terraform Plugin Framework-related code.

hashicorp · Jul 28, 2022 · 06c1276 · 06c1276
1 parent c8df06f
commit 06c1276
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 2 deletions.
diff --git a/internal/provider/fwprovider/duration.go b/internal/provider/fwprovider/duration.go
@@ -1,3 +1,4 @@
+// TODO: Move this to a shared 'types' package.
 package fwprovider
 
 import (

diff --git a/internal/provider/fwprovider/duration_test.go b/internal/provider/fwprovider/duration_test.go
@@ -1,3 +1,4 @@
+// TODO: Move this to a shared 'types' package.
 package fwprovider_test
 
 import (

diff --git a/internal/provider/fwprovider/provider.go b/internal/provider/fwprovider/provider.go
@@ -310,7 +310,7 @@ func (p *provider) GetDataSources(ctx context.Context) (map[string]tfsdk.DataSou
 	var diags diag.Diagnostics
 	dataSources := make(map[string]tfsdk.DataSourceType)
 
-	// TODO
+	// TODO: This should be done via service-level self-registration and initializatin in the primary provider.
 	t, err := meta.NewDataSourceARNType(ctx)
 
 	if err != nil {

diff --git a/internal/provider/provider.go b/internal/provider/provider.go
@@ -738,7 +738,7 @@ func New(_ context.Context) (*schema.Provider, error) {
 			"aws_location_route_calculator":    location.DataSourceRouteCalculator(),
 			"aws_location_tracker":             location.DataSourceTracker(),
 
-			// "aws_arn":                     meta.DataSourceARN(),
+			// "aws_arn":                     meta.DataSourceARN(), // Now implemented using Terraform Plugin Framework.
 			"aws_billing_service_account": meta.DataSourceBillingServiceAccount(),
 			"aws_default_tags":            meta.DataSourceDefaultTags(),
 			"aws_ip_ranges":               meta.DataSourceIPRanges(),

diff --git a/internal/service/meta/arn.go b/internal/service/meta/arn.go
@@ -1,3 +1,4 @@
+// TODO: Move this to a shared 'types' package.
 package meta
 
 import (

diff --git a/internal/service/meta/arn_test.go b/internal/service/meta/arn_test.go
@@ -1,3 +1,4 @@
+// TODO: Move this to a shared 'types' package.
 package meta_test
 
 import (