aws_ce_cost_category: effective start has to be passed for every upda…

…te else aws takes the first day of the current month as effective start date
hashicorp · Mar 31, 2023 · 6be41f4 · 6be41f4
1 parent 88bfbd5
commit 6be41f4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.changelog/30369.txt b/.changelog/30369.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_ce_cost_explorer: Fixed `effective_start` being reset on any changes despite `effective_start` having the same value
+```
diff --git a/internal/service/ce/cost_category.go b/internal/service/ce/cost_category.go
@@ -468,6 +468,7 @@ func resourceCostCategoryUpdate(ctx context.Context, d *schema.ResourceData, met
 	if d.HasChangesExcept("tags", "tags_all") {
 		input := &costexplorer.UpdateCostCategoryDefinitionInput{
 			CostCategoryArn: aws.String(d.Id()),
+			EffectiveStart:  aws.String(d.Get("effective_start").(string)),
 			Rules:           expandCostCategoryRules(d.Get("rule").(*schema.Set).List()),
 			RuleVersion:     aws.String(d.Get("rule_version").(string)),
 		}
@@ -480,10 +481,6 @@ func resourceCostCategoryUpdate(ctx context.Context, d *schema.ResourceData, met
 			input.SplitChargeRules = expandCostCategorySplitChargeRules(d.Get("split_charge_rule").(*schema.Set).List())
 		}
 
-		if d.HasChange("effective_start") {
-			input.EffectiveStart = aws.String(d.Get("effective_start").(string))
-		}
-
 		_, err := conn.UpdateCostCategoryDefinitionWithContext(ctx, input)
 
 		if err != nil {