Skip to content

Commit

Permalink
data-source/aws_db_instance: Address PR #8317 feedback
Browse files Browse the repository at this point in the history
Output from acceptance testing:

```
--- PASS: TestAccAWSDbInstanceDataSource_basic (526.46s)
```
  • Loading branch information
bflad committed May 7, 2019
1 parent 28eaaf7 commit a2df236
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions aws/data_source_aws_db_instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,11 @@ func dataSourceAwsDbInstance() *schema.Resource {
Computed: true,
},

"resource_id": {
Type: schema.TypeString,
Computed: true,
},

"storage_encrypted": {
Type: schema.TypeBool,
Computed: true,
Expand Down
1 change: 1 addition & 0 deletions aws/data_source_aws_db_instance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ func TestAccAWSDbInstanceDataSource_basic(t *testing.T) {
resource.TestCheckResourceAttrSet("data.aws_db_instance.bar", "port"),
resource.TestCheckResourceAttrSet("data.aws_db_instance.bar", "enabled_cloudwatch_logs_exports.0"),
resource.TestCheckResourceAttrSet("data.aws_db_instance.bar", "enabled_cloudwatch_logs_exports.1"),
resource.TestCheckResourceAttrPair("data.aws_db_instance.bar", "resource_id", "aws_db_instance.bar", "resource_id"),
),
},
},
Expand Down
1 change: 1 addition & 0 deletions website/docs/d/db_instance.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ In addition to all arguments above, the following attributes are exported:
* `preferred_backup_window` - Specifies the daily time range during which automated backups are created.
* `preferred_maintenance_window` - Specifies the weekly time range during which system maintenance can occur in UTC.
* `publicly_accessible` - Specifies the accessibility options for the DB instance.
* `resource_id` - The RDS Resource ID of this instance.
* `storage_encrypted` - Specifies whether the DB instance is encrypted.
* `storage_type` - Specifies the storage type associated with DB instance.
* `timezone` - The time zone of the DB instance.
Expand Down

0 comments on commit a2df236

Please sign in to comment.