Skip to content

Commit

Permalink
r/aws_ec2_traffic_mirror_target: Use '(acctest.ConfigVPCWithSubnets' …
Browse files Browse the repository at this point in the history 
…in acceptance test configurations.
  • Loading branch information
@ewbankkit
ewbankkit committed Sep 29, 2022
1 parent 6a8cee0 commit c7ea6ef
Showing 1 changed file with 49 additions and 107 deletions.
156 changes: 49 additions & 107 deletions internal/service/ec2/vpc_traffic_mirror_target_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func TestAccVPCTrafficMirrorTarget_nlb(t *testing.T) {
acctest.CheckResourceAttrAccountID(resourceName, "owner_id"),
acctest.MatchResourceAttrRegionalARN(resourceName, "arn", "ec2", regexp.MustCompile(`traffic-mirror-target/tmt-.+`)),
resource.TestCheckResourceAttr(resourceName, "description", description),
resource.TestCheckResourceAttrPair(resourceName, "network_load_balancer_arn", "aws_lb.lb", "arn"),
resource.TestCheckResourceAttrPair(resourceName, "network_load_balancer_arn", "aws_lb.test", "arn"),
resource.TestCheckResourceAttr(resourceName, "tags.%", "0"),
),
},
Expand Down Expand Up @@ -161,7 +161,6 @@ func TestAccVPCTrafficMirrorTarget_disappears(t *testing.T) {
}

func TestAccVPCTrafficMirrorTarget_gwlb(t *testing.T) {

resourceName := "aws_ec2_traffic_mirror_target.test"
rName := fmt.Sprintf("tf-acc-test-%s", sdkacctest.RandString(10))
description := "test gwlb endpoint target"
Expand Down Expand Up @@ -191,6 +190,36 @@ func TestAccVPCTrafficMirrorTarget_gwlb(t *testing.T) {
})
}

func testAccCheckTrafficMirrorTargetDestroy(s *terraform.State) error {
conn := acctest.Provider.Meta().(*conns.AWSClient).EC2Conn

for _, rs := range s.RootModule().Resources {
if rs.Type != "aws_ec2_traffic_mirror_target" {
continue
}

out, err := conn.DescribeTrafficMirrorTargets(&ec2.DescribeTrafficMirrorTargetsInput{
TrafficMirrorTargetIds: []*string{
aws.String(rs.Primary.ID),
},
})

if tfawserr.ErrCodeEquals(err, "InvalidTrafficMirrorTargetId.NotFound") {
continue
}

if err != nil {
return err
}

if len(out.TrafficMirrorTargets) != 0 {
return fmt.Errorf("Traffic mirror target %s still not destroyed", rs.Primary.ID)
}
}

return nil
}

func testAccCheckTrafficMirrorTargetExists(name string, target *ec2.TrafficMirrorTarget) resource.TestCheckFunc {
return func(s *terraform.State) error {
rs, ok := s.RootModule().Resources[name]
Expand Down Expand Up @@ -222,79 +251,33 @@ func testAccCheckTrafficMirrorTargetExists(name string, target *ec2.TrafficMirro
}
}

func testAccTrafficMirrorTargetConfigBase(rName string) string {
return fmt.Sprintf(`
data "aws_availability_zones" "azs" {
state = "available"
filter {
name = "opt-in-status"
values = ["opt-in-not-required"]
}
}
resource "aws_vpc" "vpc" {
cidr_block = "10.0.0.0/16"
tags = {
Name = %[1]q
}
}
resource "aws_subnet" "sub1" {
vpc_id = aws_vpc.vpc.id
cidr_block = "10.0.0.0/24"
availability_zone = data.aws_availability_zones.azs.names[0]
tags = {
Name = %[1]q
}
}
resource "aws_subnet" "sub2" {
vpc_id = aws_vpc.vpc.id
cidr_block = "10.0.1.0/24"
availability_zone = data.aws_availability_zones.azs.names[1]
tags = {
Name = %[1]q
}
}
`, rName)
}

func testAccVPCTrafficMirrorTargetConfig_nlb(rName, description string) string {
return acctest.ConfigCompose(testAccTrafficMirrorTargetConfigBase(rName), fmt.Sprintf(`
resource "aws_lb" "lb" {
return acctest.ConfigCompose(acctest.ConfigVPCWithSubnets(rName, 2), fmt.Sprintf(`
resource "aws_lb" "test" {
name = %[1]q
internal = true
load_balancer_type = "network"
subnets = [aws_subnet.sub1.id, aws_subnet.sub2.id]
subnets = aws_subnet.test[*].id
enable_deletion_protection = false
tags = {
Name = %[1]q
Environment = "production"
}
}
resource "aws_ec2_traffic_mirror_target" "test" {
description = %[2]q
network_load_balancer_arn = aws_lb.lb.arn
network_load_balancer_arn = aws_lb.test.arn
}
`, rName, description))
}

func testAccVPCTrafficMirrorTargetConfig_eni(rName, description string) string {
return acctest.ConfigCompose(
testAccTrafficMirrorTargetConfigBase(rName),
acctest.ConfigVPCWithSubnets(rName, 1),
acctest.ConfigLatestAmazonLinuxHVMEBSAMI(),
fmt.Sprintf(`
resource "aws_instance" "src" {
resource "aws_instance" "test" {
ami = data.aws_ami.amzn-ami-minimal-hvm-ebs.id
instance_type = "t2.micro"
subnet_id = aws_subnet.sub1.id
subnet_id = aws_subnet.test[0].id
tags = {
Name = %[1]q
Expand All @@ -303,30 +286,25 @@ resource "aws_instance" "src" {
resource "aws_ec2_traffic_mirror_target" "test" {
description = %[2]q
network_interface_id = aws_instance.src.primary_network_interface_id
network_interface_id = aws_instance.test.primary_network_interface_id
}
`, rName, description))
}

func testAccVPCTrafficMirrorTargetConfig_tags1(rName, description, tagKey1, tagValue1 string) string {
return acctest.ConfigCompose(testAccTrafficMirrorTargetConfigBase(rName), fmt.Sprintf(`
resource "aws_lb" "lb" {
return acctest.ConfigCompose(acctest.ConfigVPCWithSubnets(rName, 2), fmt.Sprintf(`
resource "aws_lb" "test" {
name = %[1]q
internal = true
load_balancer_type = "network"
subnets = [aws_subnet.sub1.id, aws_subnet.sub2.id]
subnets = aws_subnet.test[*].id
enable_deletion_protection = false
tags = {
Name = %[1]q
Environment = "production"
}
}
resource "aws_ec2_traffic_mirror_target" "test" {
description = %[2]q
network_load_balancer_arn = aws_lb.lb.arn
network_load_balancer_arn = aws_lb.test.arn
tags = {
%[3]q = %[4]q
Expand All @@ -336,24 +314,19 @@ resource "aws_ec2_traffic_mirror_target" "test" {
}

func testAccVPCTrafficMirrorTargetConfig_tags2(rName, description, tagKey1, tagValue1, tagKey2, tagValue2 string) string {
return acctest.ConfigCompose(testAccTrafficMirrorTargetConfigBase(rName), fmt.Sprintf(`
resource "aws_lb" "lb" {
return acctest.ConfigCompose(acctest.ConfigVPCWithSubnets(rName, 2), fmt.Sprintf(`
resource "aws_lb" "test" {
name = %[1]q
internal = true
load_balancer_type = "network"
subnets = [aws_subnet.sub1.id, aws_subnet.sub2.id]
subnets = aws_subnet.test[*].id
enable_deletion_protection = false
tags = {
Name = %[1]q
Environment = "production"
}
}
resource "aws_ec2_traffic_mirror_target" "test" {
description = %[2]q
network_load_balancer_arn = aws_lb.lb.arn
network_load_balancer_arn = aws_lb.test.arn
tags = {
%[3]q = %[4]q
Expand All @@ -368,11 +341,10 @@ func testAccVPCTrafficMirrorTargetConfig_gwlb(rName, description string) string
testAccVPCEndpointConfig_gatewayLoadBalancer(rName),
fmt.Sprintf(`
resource "aws_ec2_traffic_mirror_target" "test" {
description = %[2]q
description = %[1]q
gateway_load_balancer_endpoint_id = aws_vpc_endpoint.test.id
depends_on = [aws_vpc_endpoint.test]
}
`, rName, description))
`, description))
}

func testAccPreCheckTrafficMirrorTarget(t *testing.T) {
Expand All @@ -388,33 +360,3 @@ func testAccPreCheckTrafficMirrorTarget(t *testing.T) {
t.Fatal("Unexpected PreCheck error: ", err)
}
}

func testAccCheckTrafficMirrorTargetDestroy(s *terraform.State) error {
conn := acctest.Provider.Meta().(*conns.AWSClient).EC2Conn

for _, rs := range s.RootModule().Resources {
if rs.Type != "aws_ec2_traffic_mirror_target" {
continue
}

out, err := conn.DescribeTrafficMirrorTargets(&ec2.DescribeTrafficMirrorTargetsInput{
TrafficMirrorTargetIds: []*string{
aws.String(rs.Primary.ID),
},
})

if tfawserr.ErrCodeEquals(err, "InvalidTrafficMirrorTargetId.NotFound") {
continue
}

if err != nil {
return err
}

if len(out.TrafficMirrorTargets) != 0 {
return fmt.Errorf("Traffic mirror target %s still not destroyed", rs.Primary.ID)
}
}

return nil
}

0 comments on commit c7ea6ef

Please sign in to comment.