d/aws_elasticache_cluster: Remove 'security_group_names'.

hashicorp · Apr 25, 2023 · dde3583 · dde3583
1 parent ede2b39
commit dde3583
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 24 deletions.
diff --git a/.changelog/30966.txt b/.changelog/30966.txt
@@ -1,23 +1,27 @@
 ```release-note:breaking-change
-provider: With the retirement of EC2-Classic the`aws_db_security_group` resource has been removed
+provider: With the retirement of EC2-Classic the `aws_db_security_group` resource has been removed
 ```
 
 ```release-note:breaking-change
-provider: With the retirement of EC2-Classic the`aws_elasticache_security_group` resource has been removed
+provider: With the retirement of EC2-Classic the `aws_elasticache_security_group` resource has been removed
 ```
 
 ```release-note:breaking-change
-provider: With the retirement of EC2-Classic the`aws_redshift_security_group` resource has been removed
+provider: With the retirement of EC2-Classic the `aws_redshift_security_group` resource has been removed
 ```
 
 ```release-note:breaking-change
-resource/aws_db_instance: With the retirement of EC2-Classic the`security_group_names` attribute has been removed
+resource/aws_db_instance: With the retirement of EC2-Classic the `security_group_names` attribute has been removed
 ```
 
 ```release-note:breaking-change
-data-source/aws_db_instance: With the retirement of EC2-Classic the`db_security_groups` attribute has been removed
+data-source/aws_db_instance: With the retirement of EC2-Classic the `db_security_groups` attribute has been removed
 ```
 
 ```release-note:breaking-change
-resource/aws_elasticache_cluster: With the retirement of EC2-Classic the`security_group_names` attribute has been removed
+resource/aws_elasticache_cluster: With the retirement of EC2-Classic the `security_group_names` attribute has been removed
+```
+
+```release-note:breaking-change
+data-source/aws_elasticache_cluster: With the retirement of EC2-Classic the `security_group_names` attribute has been removed
 ```
diff --git a/internal/service/elasticache/cluster_data_source.go b/internal/service/elasticache/cluster_data_source.go
@@ -151,11 +151,6 @@ func DataSourceCluster() *schema.Resource {
 				Computed: true,
 				Elem:     &schema.Schema{Type: schema.TypeString},
 			},
-			"security_group_names": {
-				Type:     schema.TypeSet,
-				Computed: true,
-				Elem:     &schema.Schema{Type: schema.TypeString},
-			},
 			"snapshot_retention_limit": {
 				Type:     schema.TypeInt,
 				Computed: true,
@@ -198,7 +193,6 @@ func dataSourceClusterRead(ctx context.Context, d *schema.ResourceData, meta int
 	d.Set("ip_discovery", cluster.IpDiscovery)
 	d.Set("network_type", cluster.NetworkType)
 	d.Set("preferred_outpost_arn", cluster.PreferredOutpostArn)
-	d.Set("security_group_names", flattenSecurityGroupNames(cluster.CacheSecurityGroups))
 	d.Set("security_group_ids", flattenSecurityGroupIDs(cluster.SecurityGroups))
 
 	if cluster.CacheParameterGroup != nil {

diff --git a/internal/service/elasticache/cluster_data_source_test.go b/internal/service/elasticache/cluster_data_source_test.go
@@ -10,7 +10,7 @@ import (
 	"github.com/hashicorp/terraform-provider-aws/internal/acctest"
 )
 
-func TestAccElastiCacheClusterDataSource_Data_basic(t *testing.T) {
+func TestAccElastiCacheClusterDataSource_basic(t *testing.T) {
 	ctx := acctest.Context(t)
 	if testing.Short() {
 		t.Skip("skipping long-running test in short mode")

diff --git a/internal/service/elasticache/flex.go b/internal/service/elasticache/flex.go
@@ -15,16 +15,6 @@ func flattenSecurityGroupIDs(securityGroups []*elasticache.SecurityGroupMembersh
 	return result
 }
 
-func flattenSecurityGroupNames(securityGroups []*elasticache.CacheSecurityGroupMembership) []string {
-	result := make([]string, 0, len(securityGroups))
-	for _, sg := range securityGroups {
-		if sg.CacheSecurityGroupName != nil {
-			result = append(result, *sg.CacheSecurityGroupName)
-		}
-	}
-	return result
-}
-
 func flattenLogDeliveryConfigurations(logDeliveryConfiguration []*elasticache.LogDeliveryConfiguration) []map[string]interface{} {
 	if len(logDeliveryConfiguration) == 0 {
 		return nil

diff --git a/website/docs/d/elasticache_cluster.html.markdown b/website/docs/d/elasticache_cluster.html.markdown
@@ -35,7 +35,6 @@ In addition to all arguments above, the following attributes are exported:
 * `ip_discovery` - The IP version advertised in the discovery protocol.
 * `network_type` - The IP versions for cache cluster connections.
 * `subnet_group_name` – Name of the subnet group associated to the cache cluster.
-* `security_group_names` – List of security group names associated with this cache cluster.
 * `security_group_ids` – List VPC security groups associated with the cache cluster.
 * `parameter_group_name` – Name of the parameter group associated with this cache cluster.
 * `replication_group_id` - The replication group to which this cache cluster belongs.