Skip to content

Commit

Permalink
Merge pull request #25889 from hashicorp/f-r/aws_redshiftserverless_n…
Browse files Browse the repository at this point in the history
…amespace

New resource: `aws_redshiftserverless_namespace`
  • Loading branch information
ewbankkit authored Jul 19, 2022
2 parents 3aba64f + 0df05bd commit e59576a
Show file tree
Hide file tree
Showing 26 changed files with 996 additions and 81 deletions.
3 changes: 3 additions & 0 deletions .changelog/25889.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:new-resource
aws_redshiftserverless_namespace
```
2 changes: 2 additions & 0 deletions .github/labeler-issue-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,8 @@ service/redshift:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_redshift_'
service/redshiftdata:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_redshiftdata_'
service/redshiftserverless:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_redshiftserverless_'
service/rekognition:
- '((\*|-)\s*`?|(data|resource)\s+"?)aws_rekognition_'
service/resiliencehub:
Expand Down
3 changes: 3 additions & 0 deletions .github/labeler-pr-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,9 @@ service/redshift:
service/redshiftdata:
- 'internal/service/redshiftdata/**/*'
- 'website/**/redshiftdata_*'
service/redshiftserverless:
- 'internal/service/redshiftserverless/**/*'
- 'website/**/redshiftserverless_*'
service/rekognition:
- 'internal/service/rekognition/**/*'
- 'website/**/rekognition_*'
Expand Down
16 changes: 16 additions & 0 deletions .semgrep-service-name0.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2954,3 +2954,19 @@ rules:
patterns:
- pattern-regex: "(?i)ConfigService"
severity: WARNING
- id: connect-in-func-name
languages:
- go
message: Do not use "Connect" in func name inside connect package
paths:
include:
- internal/service/connect
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Connect"
- pattern-not-regex: .*uickConnect.*
- pattern-not-regex: ^TestAcc.*
severity: WARNING
44 changes: 28 additions & 16 deletions .semgrep-service-name1.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,5 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: connect-in-func-name
languages:
- go
message: Do not use "Connect" in func name inside connect package
paths:
include:
- internal/service/connect
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Connect"
- pattern-not-regex: .*uickConnect.*
- pattern-not-regex: ^TestAcc.*
severity: WARNING
- id: connect-in-test-name
languages:
- go
Expand Down Expand Up @@ -2960,3 +2944,31 @@ rules:
- pattern-not-regex: "^TestAccInspector"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: inspector-in-const-name
languages:
- go
message: Do not use "Inspector" in const name inside inspector package
paths:
include:
- internal/service/inspector
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Inspector"
severity: WARNING
- id: inspector-in-var-name
languages:
- go
message: Do not use "Inspector" in var name inside inspector package
paths:
include:
- internal/service/inspector
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Inspector"
severity: WARNING
71 changes: 43 additions & 28 deletions .semgrep-service-name2.yml
Original file line number Diff line number Diff line change
@@ -1,33 +1,5 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: inspector-in-const-name
languages:
- go
message: Do not use "Inspector" in const name inside inspector package
paths:
include:
- internal/service/inspector
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Inspector"
severity: WARNING
- id: inspector-in-var-name
languages:
- go
message: Do not use "Inspector" in var name inside inspector package
paths:
include:
- internal/service/inspector
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Inspector"
severity: WARNING
- id: iot-in-func-name
languages:
- go
Expand Down Expand Up @@ -2954,3 +2926,46 @@ rules:
- pattern-not-regex: "^TestAccRedshift"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: redshift-in-const-name
languages:
- go
message: Do not use "Redshift" in const name inside redshift package
paths:
include:
- internal/service/redshift
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
severity: WARNING
- id: redshift-in-var-name
languages:
- go
message: Do not use "Redshift" in var name inside redshift package
paths:
include:
- internal/service/redshift
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
severity: WARNING
- id: redshiftdata-in-func-name
languages:
- go
message: Do not use "RedshiftData" in func name inside redshiftdata package
paths:
include:
- internal/service/redshiftdata
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)RedshiftData"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
89 changes: 52 additions & 37 deletions .semgrep-service-name3.yml
Original file line number Diff line number Diff line change
@@ -1,67 +1,67 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: redshift-in-const-name
- id: redshiftdata-in-test-name
languages:
- go
message: Do not use "Redshift" in const name inside redshift package
message: Include "RedshiftData" in test name
paths:
include:
- internal/service/redshift
- internal/service/redshiftdata/*_test.go
patterns:
- pattern: const $NAME = ...
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
- pattern-not-regex: "^TestAccRedshiftData"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: redshift-in-var-name
- id: redshiftdata-in-const-name
languages:
- go
message: Do not use "Redshift" in var name inside redshift package
message: Do not use "RedshiftData" in const name inside redshiftdata package
paths:
include:
- internal/service/redshift
- internal/service/redshiftdata
patterns:
- pattern: var $NAME = ...
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
- pattern-regex: "(?i)RedshiftData"
severity: WARNING
- id: redshiftdata-in-func-name
- id: redshiftdata-in-var-name
languages:
- go
message: Do not use "RedshiftData" in func name inside redshiftdata package
message: Do not use "RedshiftData" in var name inside redshiftdata package
paths:
include:
- internal/service/redshiftdata
patterns:
- pattern: func $NAME( ... ) { ... }
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)RedshiftData"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
- id: redshiftdata-in-test-name
- id: redshiftdataapiservice-in-func-name
languages:
- go
message: Include "RedshiftData" in test name
message: Do not use "redshiftdataapiservice" in func name inside redshiftdata package
paths:
include:
- internal/service/redshiftdata/*_test.go
- internal/service/redshiftdata
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccRedshiftData"
- pattern-regex: ^TestAcc.*
- pattern-regex: "(?i)redshiftdataapiservice"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
- id: redshiftdata-in-const-name
- id: redshiftdataapiservice-in-const-name
languages:
- go
message: Do not use "RedshiftData" in const name inside redshiftdata package
message: Do not use "redshiftdataapiservice" in const name inside redshiftdata package
paths:
include:
- internal/service/redshiftdata
Expand All @@ -70,12 +70,12 @@ rules:
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)RedshiftData"
- pattern-regex: "(?i)redshiftdataapiservice"
severity: WARNING
- id: redshiftdata-in-var-name
- id: redshiftdataapiservice-in-var-name
languages:
- go
message: Do not use "RedshiftData" in var name inside redshiftdata package
message: Do not use "redshiftdataapiservice" in var name inside redshiftdata package
paths:
include:
- internal/service/redshiftdata
Expand All @@ -84,50 +84,65 @@ rules:
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)RedshiftData"
- pattern-regex: "(?i)redshiftdataapiservice"
severity: WARNING
- id: redshiftdataapiservice-in-func-name
- id: redshiftserverless-in-func-name
languages:
- go
message: Do not use "redshiftdataapiservice" in func name inside redshiftdata package
message: Do not use "RedshiftServerless" in func name inside redshiftserverless package
paths:
include:
- internal/service/redshiftdata
- internal/service/redshiftserverless
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)redshiftdataapiservice"
- pattern-regex: "(?i)RedshiftServerless"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
- id: redshiftdataapiservice-in-const-name
- id: redshiftserverless-in-test-name
languages:
- go
message: Do not use "redshiftdataapiservice" in const name inside redshiftdata package
message: Include "RedshiftServerless" in test name
paths:
include:
- internal/service/redshiftdata
- internal/service/redshiftserverless/*_test.go
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccRedshiftServerless"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: redshiftserverless-in-const-name
languages:
- go
message: Do not use "RedshiftServerless" in const name inside redshiftserverless package
paths:
include:
- internal/service/redshiftserverless
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)redshiftdataapiservice"
- pattern-regex: "(?i)RedshiftServerless"
severity: WARNING
- id: redshiftdataapiservice-in-var-name
- id: redshiftserverless-in-var-name
languages:
- go
message: Do not use "redshiftdataapiservice" in var name inside redshiftdata package
message: Do not use "RedshiftServerless" in var name inside redshiftserverless package
paths:
include:
- internal/service/redshiftdata
- internal/service/redshiftserverless
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)redshiftdataapiservice"
- pattern-regex: "(?i)RedshiftServerless"
severity: WARNING
- id: resourcegroups-in-func-name
languages:
Expand Down
1 change: 1 addition & 0 deletions .teamcity/components/generated/services_all.kt
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ val services = mapOf(
"rds" to ServiceSpec("RDS (Relational Database)", vpcLock = true),
"redshift" to ServiceSpec("Redshift", vpcLock = true),
"redshiftdata" to ServiceSpec("Redshift Data"),
"redshiftserverless" to ServiceSpec("Redshift Serverless"),
"resourcegroups" to ServiceSpec("Resource Groups"),
"resourcegroupstaggingapi" to ServiceSpec("Resource Groups Tagging"),
"rolesanywhere" to ServiceSpec("Roles Anywhere"),
Expand Down
1 change: 1 addition & 0 deletions infrastructure/repository/labels-service.tf
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ variable "service_labels" {
"rdsdata",
"redshift",
"redshiftdata",
"redshiftserverless",
"rekognition",
"resiliencehub",
"resourcegroups",
Expand Down
2 changes: 2 additions & 0 deletions internal/conns/awsclient_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit e59576a

Please sign in to comment.