Elastic Inference Accelerators for SageMaker

[WriteCodeEveryday]

Adds Elastic Inference Accelerators as an option for SageMaker notebooks.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10208

Release note for CHANGELOG:

Adds Elastic Inference as

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
MISSING
...

[WriteCodeEveryday]

This change is missing go fmt as it was created a large change (30+ files). I'm trying to get my test suite up and running but it appears to be having issues.

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerNotebookInstance_' PKG=sagemaker ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 3  -run=TestAccSageMakerNotebookInstance_ -timeout 180m
=== RUN   TestAccSageMakerNotebookInstance_basic
=== PAUSE TestAccSageMakerNotebookInstance_basic
=== RUN   TestAccSageMakerNotebookInstance_imds
=== PAUSE TestAccSageMakerNotebookInstance_imds
=== RUN   TestAccSageMakerNotebookInstance_update
=== PAUSE TestAccSageMakerNotebookInstance_update
=== RUN   TestAccSageMakerNotebookInstance_volumeSize
=== PAUSE TestAccSageMakerNotebookInstance_volumeSize
=== RUN   TestAccSageMakerNotebookInstance_lifecycleName
=== PAUSE TestAccSageMakerNotebookInstance_lifecycleName
=== RUN   TestAccSageMakerNotebookInstance_tags
=== PAUSE TestAccSageMakerNotebookInstance_tags
=== RUN   TestAccSageMakerNotebookInstance_kms
=== PAUSE TestAccSageMakerNotebookInstance_kms
=== RUN   TestAccSageMakerNotebookInstance_disappears
=== PAUSE TestAccSageMakerNotebookInstance_disappears
=== RUN   TestAccSageMakerNotebookInstance_Root_access
=== PAUSE TestAccSageMakerNotebookInstance_Root_access
=== RUN   TestAccSageMakerNotebookInstance_Platform_identifier
=== PAUSE TestAccSageMakerNotebookInstance_Platform_identifier
=== RUN   TestAccSageMakerNotebookInstance_DirectInternet_access
=== PAUSE TestAccSageMakerNotebookInstance_DirectInternet_access
=== RUN   TestAccSageMakerNotebookInstance_DefaultCode_repository
=== PAUSE TestAccSageMakerNotebookInstance_DefaultCode_repository
=== RUN   TestAccSageMakerNotebookInstance_AdditionalCode_repositories
=== PAUSE TestAccSageMakerNotebookInstance_AdditionalCode_repositories
=== RUN   TestAccSageMakerNotebookInstance_DefaultCodeRepository_sageMakerRepo
=== PAUSE TestAccSageMakerNotebookInstance_DefaultCodeRepository_sageMakerRepo
=== RUN   TestAccSageMakerNotebookInstance_acceleratorTypes
=== PAUSE TestAccSageMakerNotebookInstance_acceleratorTypes
=== CONT  TestAccSageMakerNotebookInstance_basic
=== CONT  TestAccSageMakerNotebookInstance_Root_access
=== CONT  TestAccSageMakerNotebookInstance_AdditionalCode_repositories
--- PASS: TestAccSageMakerNotebookInstance_basic (428.98s)
=== CONT  TestAccSageMakerNotebookInstance_acceleratorTypes
--- PASS: TestAccSageMakerNotebookInstance_acceleratorTypes (1142.76s)
=== CONT  TestAccSageMakerNotebookInstance_DirectInternet_access
--- PASS: TestAccSageMakerNotebookInstance_DirectInternet_access (759.71s)
=== CONT  TestAccSageMakerNotebookInstance_DefaultCode_repository
=== CONT  TestAccSageMakerNotebookInstance_Platform_identifier
--- PASS: TestAccSageMakerNotebookInstance_Root_access (795.57s)
--- PASS: TestAccSageMakerNotebookInstance_AdditionalCode_repositories (1533.78s)
=== CONT  TestAccSageMakerNotebookInstance_DefaultCodeRepository_sageMakerRepo
--- PASS: TestAccSageMakerNotebookInstance_Platform_identifier (765.05s)
=== CONT  TestAccSageMakerNotebookInstance_lifecycleName
--- PASS: TestAccSageMakerNotebookInstance_DefaultCode_repository (1188.18s)
=== CONT  TestAccSageMakerNotebookInstance_disappears
--- PASS: TestAccSageMakerNotebookInstance_disappears (420.78s)
=== CONT  TestAccSageMakerNotebookInstance_kms
--- PASS: TestAccSageMakerNotebookInstance_DefaultCodeRepository_sageMakerRepo (1151.62s)
=== CONT  TestAccSageMakerNotebookInstance_tags
--- PASS: TestAccSageMakerNotebookInstance_lifecycleName (1149.72s)
=== CONT  TestAccSageMakerNotebookInstance_update
--- PASS: TestAccSageMakerNotebookInstance_kms (314.78s)
=== CONT  TestAccSageMakerNotebookInstance_volumeSize
--- PASS: TestAccSageMakerNotebookInstance_tags (438.12s)
=== CONT  TestAccSageMakerNotebookInstance_imds
--- PASS: TestAccSageMakerNotebookInstance_update (726.20s)
--- PASS: TestAccSageMakerNotebookInstance_volumeSize (1036.36s)
--- PASS: TestAccSageMakerNotebookInstance_imds (862.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	3997.506s

[ewbankkit]

@WriteCodeEveryday Thanks for the contribution 🎉 👏.

[ewbankkit]

% make providerlint golangci-lint                                                                           
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

[github-actions]

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.