[WIP]r/sagemaker_notebook_instance - add support for accelerator_types argument
#15798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/M
|
Waiting for AWS to increase my quota for Sagemaker accelerator from default zero |
DrFaust92
added
the
enhancement
DrFaust92
changed the title
accelerator_types argument + url and network_interface_id attributesaccelerator_types argument
|
Acceptance test failure: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_accelerator_types'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_accelerator_types -timeout 120m
=== RUN TestAccAWSSagemakerNotebookInstance_accelerator_types
=== PAUSE TestAccAWSSagemakerNotebookInstance_accelerator_types
=== CONT TestAccAWSSagemakerNotebookInstance_accelerator_types
resource_aws_sagemaker_notebook_instance_test.go:301: Step 1/4 error: Check failed: Check 4/4 error: aws_sagemaker_notebook_instance.test: Attribute 'accelerator_types.0' expected "1ml.eia1.medium", got "ml.eia1.medium"
--- FAIL: TestAccAWSSagemakerNotebookInstance_accelerator_types (306.69s)
FAIL
FAIL github.com/terraform-providers/terraform-provider-aws/aws 306.746s
FAIL
GNUmakefile:27: recipe for target 'testacc' failed
make: *** [testacc] Error 1 |
DrFaust92
force-pushed
the
r/sagemaker_notebook_instance_ei
branch
from
056c81d
to
6df9963
Compare
ghost
added
size/XS
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #10208
Supersedes #10210
Release note for CHANGELOG:
Output from acceptance testing: