Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for importing AWS Batch resource types #11207

Closed
jrr opened this issue Dec 9, 2019 · 5 comments · Fixed by #11407
Closed

Support for importing AWS Batch resource types #11207

jrr opened this issue Dec 9, 2019 · 5 comments · Fixed by #11407
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/batch Issues and PRs that pertain to the batch service.
Milestone
v2.48.0

Comments

@jrr
Copy link

jrr commented Dec 9, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Today I attempted to import some AWS Batch resources I'd created in AWS console, only to discover import is not supported for them. The Resource Importability doc says to file an issue on the provider repo, so here we are.

New or Affected Resource(s)

Specifically, I tried to import the following resource types:

  • aws_batch_compute_environment
  • aws_batch_job_queue
  • aws_batch_job_definition

And received messages like these:

Error: resource aws_batch_compute_environment doesn't support import

Error: resource aws_batch_job_queue doesn't support import

Error: resource aws_batch_job_definition doesn't support import
@jrr jrr added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 9, 2019
@ghost ghost added the service/batch Issues and PRs that pertain to the batch service. label Dec 9, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 9, 2019
@bflad bflad added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 9, 2019
prabusah added a commit to prabusah/terraform-provider-aws that referenced this issue Dec 15, 2019
@prabusah
Add import support for aws_batch_compute_environment Relates - hashic…
9e8ffe6 
…orp#11207
@prabusah prabusah mentioned this issue Dec 15, 2019
Merged
@bflad
Copy link
Contributor

bflad commented Dec 18, 2019

Support for importing aws_batch_compute_environment resources has been merged and will release with version 2.43.0 of the Terraform AWS Provider, tomorrow. Thanks to @prabusah for the implementation. 👍

prabusah added a commit to prabusah/terraform-provider-aws that referenced this issue Dec 22, 2019
@prabusah
Add import support for aws_batch_job_queue hashicorp#11207
f3732de
This was referenced Dec 22, 2019
Merged
Merged
@bflad bflad modified the milestone: v2.44.0 Jan 6, 2020
@bflad
Copy link
Contributor

bflad commented Jan 6, 2020

Support for importing aws_batch_job_queue resources has been merged and will release with version 2.44.0 of the Terraform AWS Provider, Thursday this week. Thanks again to @prabusha for the implementation.

The aws_batch_job_definition resource will require some additional work before it can properly support import, so it may not be implemented as quick as the above.

@bflad bflad added this to the v2.48.0 milestone Feb 6, 2020
@bflad
Copy link
Contributor

bflad commented Feb 6, 2020

Support for importing aws_batch_job_definition resources has been merged and will release with version 2.48.0 of the Terraform AWS Provider, later today.

@ghost
Copy link

ghost commented Feb 7, 2020

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/batch Issues and PRs that pertain to the batch service.
Projects
None yet
Milestone
v2.48.0
Development

Successfully merging a pull request may close this issue.

Add import support for aws_batch_job_definition prabusah/terraform-provider-aws
2 participants
@jrr @bflad