aws_sns_topic_subscription resource produced new value for was present but now absent #11737

jochen42 · 2020-01-23T16:53:06Z

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

$ terraform -v
Terraform v0.12.20

provider.aws v2.45.0

Affected Resource(s)

aws_sns_topic_subscription

Terraform Configuration Files

resource "aws_sns_topic_subscription" "oncall-topic-subscription" {
  endpoint               = "https://alert.examlpe.com/somehook"
  protocol               = "HTTPS"
  topic_arn              = aws_sns_topic.oncall-topic.arn
  endpoint_auto_confirms = true
}

Debug Output

Panic Output

Expected Behavior

It's happening after upgrade from Terraform 0.11 to 0.12. Since the topic_subscription is already in state, aws and there aren't any changes, the existing subscription should keep unchanged.

Actual Behavior

Terraform fails with the following message

>> #1530018634 Error:
>> #1530018634 Error: Error: Provider produced inconsistent result after apply
>> #1530018634 Error:
>> #1530018634 Error: When applying changes to aws_sns_topic_subscription.oncall-topic-subscription,
>> #1530018634 Error: provider "registry.terraform.io/-/aws" produced an unexpected new value for
>> #1530018634 Error: was present, but now absent.
>> #1530018634 Error:
>> #1530018634 Error: This is a bug in the provider, which should be reported in the provider's own
>> #1530018634 Error: issue tracker.
>> #1530018634 Error:
>> #1530018634 Error: ============================================
>> #1530018634 Error: Base path: terraform/k28s/20_infrastructure:
>> #1530018634 Error: ERROR: Terraform apply failed
>> #1530018634 Error: ============================================
2020/01/23 15:21:48 exit status 1

Steps to Reproduce

terraform apply

Important Factoids

References

The text was updated successfully, but these errors were encountered:

jochen42 · 2020-01-23T16:54:17Z

#10473, #10930

bshilliam · 2020-01-25T01:18:55Z

Hit the same issue. In my case it looked like it was not hitting this retry logic below when it got "pending confirmation" back initially from AWS. So it would end up failing with the same error message as above.

if strings.Contains(protocol, "http") && subscriptionHasPendingConfirmation(output.SubscriptionArn) { ...

And the reason it was skipping this was because I had protocol = "HTTPS" in my aws_sns_topic_subscription definition.

I don't know how it worked with all caps in versions < 0.12. But after changing to protocol = "https" the creation and update works fine in Terraform.

I'm thinking there should be a validation of lowercase values for protocol.

amarouane-ABDELHAK · 2020-04-03T16:39:35Z

@bshilliam I am having the same problem. Where did you add subscriptionHasPendingConfirmation in output.tf file?

bshilliam · 2020-04-03T17:32:28Z

@amarouane-ABDELHAK, only change needed was to change from protocol = "HTTPS" to protocol = "https" in my tf file.

amarouane-ABDELHAK · 2020-04-03T17:37:52Z

Thank you. I have protocol sqs and it is already in lowercase. so this functionsubscriptionHasPendingConfirmation is a terraform internal function?

bshilliam · 2020-04-03T22:00:18Z

Yea @amarouane-ABDELHAK that was in the internal logic where I found my scenario wasn't triggering properly because of the uppercase HTTP.

MattMcKeithen · 2020-04-06T17:09:36Z

I've also encountered a similiar issue: #12692

ghost · 2020-04-21T17:53:10Z

Encountered just now:

Error: Provider produced inconsistent result after apply

When applying changes to module.cloudwatch-log-metric-filters.module.server-log-filter-metric-blah.aws_cloudwatch_log_metric_filter.custom,
provider "registry.terraform.io/-/aws" produced an unexpected new value for
was present, but now absent.

This is a bug in the provider, which should be reported in the provider's own issue tracker.

dtns2 · 2020-05-01T15:48:52Z

Also encountered same issue when re-attaching IAM policies to an IAM role:

Error: Provider produced inconsistent result after apply

When applying changes to
module.iam_role_default.aws_iam_role_policy_attachment.iam_role_policy_attach[3],
provider "registry.terraform.io/-/aws" produced an unexpected new value for
was present, but now absent.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.

cedriclecoz · 2020-05-20T09:49:03Z

+1 for the attaching policy to IAM role.

willcampbell433 · 2020-05-20T17:18:16Z

Encountering same issue when attaching policies to IAM role:

Error: Provider produced inconsistent result after apply

When applying changes to aws_iam_role_policy_attachment.db_ops_policy_attach,
provider "aws" produced an unexpected new value for was present, but now
absent.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.

ychenbioinfo · 2020-06-12T15:31:27Z

Same issue when attaching policies

Error: Provider produced inconsistent result after apply

When applying changes to
aws_iam_role_policy_attachment.attach-ecs-instance-role[2], provider
"registry.terraform.io/-/aws" produced an unexpected new value for was
present, but now absent.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.

magnetik · 2020-07-07T09:57:53Z

Same issue with provider 2.69.0

dsg9321 · 2020-07-14T11:32:57Z

Faced similar issue

Error: Provider produced inconsistent result after apply

When applying changes to aws_s3_bucket_object.principal_policy, provider
"registry.terraform.io/-/aws" produced an unexpected new value for was
present, but now absent.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.

Terraform version : 0.12.28

kabelak · 2020-08-18T11:34:58Z

Same issue.
Terraform: 0.12.20
AWS: 2.70.0

Error: Provider produced inconsistent result after apply
 
When applying changes to
aws_cloudwatch_metric_alarm.webserver_httpd_service[2], provider
"registry.terraform.io/-/aws" produced an unexpected new value for was
present, but now absent.
 
This is a bug in the provider, which should be reported in the provider's own
issue tracker.

gclough · 2020-09-11T15:09:54Z

Same issue, with the latest AWS provider:

 - Downloading plugin for provider "aws" (hashicorp/aws) 3.6.0...

$ terraform --version
Terraform v0.12.28

ERROR:

 Error: Provider produced inconsistent result after apply
 When applying changes to
 module.postgres-db.aws_cloudwatch_event_rule.auto_minor_version_upgrade[0],
 provider "registry.terraform.io/-/aws" produced an unexpected new value for
 was present, but now absent.
 This is a bug in the provider, which should be reported in the provider's own
 issue tracker.

sannithibalaji · 2021-01-13T13:55:30Z

faced a similar issue, but when I gave the protocol in a small case (https) it worked fine.

ignas-sakalauskas-cko · 2021-02-23T13:59:17Z

Just run into the same issue when trying to create cross-account SQS subscription.

…l consistency, enforce lowercase protocol argument validation Reference: #10225 Reference: #11737 Reference: #12692 Reference: #16695 Reference: #16796 The `protocol` validation update is to catch where the API accepts uppercase values such as `HTTPS`, but prevents proper handling when the API canonicalizes it to lowercase. The API documentation and existing Terraform documentation solely use lowercase. Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (95.60s) --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (137.43s) --- PASS: TestAccAWSSNSTopicSubscription_basic (66.20s) --- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (69.55s) --- PASS: TestAccAWSSNSTopicSubscription_disappears (74.02s) --- PASS: TestAccAWSSNSTopicSubscription_disappears_topic (75.13s) --- PASS: TestAccAWSSNSTopicSubscription_email (16.78s) --- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (71.62s) --- PASS: TestAccAWSSNSTopicSubscription_firehose (140.29s) --- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (69.77s) --- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (64.88s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSSNSTopicSubscription_basic (70.13s) --- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (106.45s) --- PASS: TestAccAWSSNSTopicSubscription_disappears (82.09s) --- PASS: TestAccAWSSNSTopicSubscription_disappears_topic (68.14s) --- PASS: TestAccAWSSNSTopicSubscription_email (20.04s) --- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (106.32s) --- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (95.36s) --- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (110.75s) --- SKIP: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (1.41s) --- SKIP: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (1.41s) --- SKIP: TestAccAWSSNSTopicSubscription_firehose (53.36s) ```

…l consistency, enforce lowercase protocol argument validation (#18475) * resource/aws_sns_topic_subscription: Handle read-after-create eventual consistency, enforce lowercase protocol argument validation Reference: #10225 Reference: #11737 Reference: #12692 Reference: #16695 Reference: #16796 The `protocol` validation update is to catch where the API accepts uppercase values such as `HTTPS`, but prevents proper handling when the API canonicalizes it to lowercase. The API documentation and existing Terraform documentation solely use lowercase. Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (95.60s) --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (137.43s) --- PASS: TestAccAWSSNSTopicSubscription_basic (66.20s) --- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (69.55s) --- PASS: TestAccAWSSNSTopicSubscription_disappears (74.02s) --- PASS: TestAccAWSSNSTopicSubscription_disappears_topic (75.13s) --- PASS: TestAccAWSSNSTopicSubscription_email (16.78s) --- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (71.62s) --- PASS: TestAccAWSSNSTopicSubscription_firehose (140.29s) --- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (69.77s) --- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (64.88s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSSNSTopicSubscription_basic (70.13s) --- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (106.45s) --- PASS: TestAccAWSSNSTopicSubscription_disappears (82.09s) --- PASS: TestAccAWSSNSTopicSubscription_disappears_topic (68.14s) --- PASS: TestAccAWSSNSTopicSubscription_email (20.04s) --- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (106.32s) --- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (95.36s) --- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (110.75s) --- SKIP: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (1.41s) --- SKIP: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (1.41s) --- SKIP: TestAccAWSSNSTopicSubscription_firehose (53.36s) ``` * Update CHANGELOG for #18475

ghost · 2021-04-01T22:57:46Z

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2021-04-30T17:10:06Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ghost added the service/sns Issues and PRs that pertain to the sns service. label Jan 23, 2020

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 23, 2020

MattMcKeithen mentioned this issue Apr 6, 2020

aws_sns_topic_subscription resource produced new value for was present but now absent #12692

Closed

ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 27, 2021

ewbankkit mentioned this issue Jan 27, 2021

aws_sns_topic_subscription apply intermittently fails with "Root resource was present, but now absent" error #16695

Closed

ewbankkit mentioned this issue Feb 8, 2021

Provider produced inconsistent result after apply when HTTPS instead of https as protocol for an aws_sns_topic_subscription #17509

Closed

bflad mentioned this issue Mar 18, 2021

Implement d.IsNewResource() Checks In Resource Read Functions #16796

Closed

bflad self-assigned this Mar 30, 2021

bflad mentioned this issue Mar 30, 2021

resource/aws_sns_topic_subscription: Handle read-after-create eventual consistency, enforce lowercase protocol argument validation #18475

Merged

bflad closed this as completed in #18475 Mar 30, 2021

github-actions bot added this to the v3.35.0 milestone Mar 30, 2021

ghost locked as resolved and limited conversation to collaborators Apr 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

aws_sns_topic_subscription resource produced new value for was present but now absent #11737

aws_sns_topic_subscription resource produced new value for was present but now absent #11737

jochen42 commented Jan 23, 2020

jochen42 commented Jan 23, 2020

bshilliam commented Jan 25, 2020

amarouane-ABDELHAK commented Apr 3, 2020

bshilliam commented Apr 3, 2020

amarouane-ABDELHAK commented Apr 3, 2020

bshilliam commented Apr 3, 2020

MattMcKeithen commented Apr 6, 2020 •

edited

Loading

ghost commented Apr 21, 2020

dtns2 commented May 1, 2020

cedriclecoz commented May 20, 2020

willcampbell433 commented May 20, 2020 •

edited

Loading

ychenbioinfo commented Jun 12, 2020 •

edited

Loading

magnetik commented Jul 7, 2020

dsg9321 commented Jul 14, 2020

kabelak commented Aug 18, 2020

gclough commented Sep 11, 2020

sannithibalaji commented Jan 13, 2021

ignas-sakalauskas-cko commented Feb 23, 2021

ghost commented Apr 1, 2021

ghost commented Apr 30, 2021

aws_sns_topic_subscription resource produced new value for was present but now absent #11737

aws_sns_topic_subscription resource produced new value for was present but now absent #11737

Comments

jochen42 commented Jan 23, 2020

Community Note

Terraform Version

Affected Resource(s)

Terraform Configuration Files

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

Important Factoids

References

jochen42 commented Jan 23, 2020

bshilliam commented Jan 25, 2020

amarouane-ABDELHAK commented Apr 3, 2020

bshilliam commented Apr 3, 2020

amarouane-ABDELHAK commented Apr 3, 2020

bshilliam commented Apr 3, 2020

MattMcKeithen commented Apr 6, 2020 • edited Loading

ghost commented Apr 21, 2020

dtns2 commented May 1, 2020

cedriclecoz commented May 20, 2020

willcampbell433 commented May 20, 2020 • edited Loading

ychenbioinfo commented Jun 12, 2020 • edited Loading

magnetik commented Jul 7, 2020

dsg9321 commented Jul 14, 2020

kabelak commented Aug 18, 2020

gclough commented Sep 11, 2020

sannithibalaji commented Jan 13, 2021

ignas-sakalauskas-cko commented Feb 23, 2021

ghost commented Apr 1, 2021

ghost commented Apr 30, 2021

MattMcKeithen commented Apr 6, 2020 •

edited

Loading

willcampbell433 commented May 20, 2020 •

edited

Loading

ychenbioinfo commented Jun 12, 2020 •

edited

Loading