Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Replace use of deprecated plugin SDK validation functions #11844

Closed
ewbankkit opened this issue Jan 31, 2020 · 4 comments · Fixed by #12378
Closed

Tech debt: Replace use of deprecated plugin SDK validation functions #11844

ewbankkit opened this issue Jan 31, 2020 · 4 comments · Fixed by #12378
Assignees
Labels
technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Jan 31, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

After the merge of #11802 certain plugin SDK validation functions used extensively in the codebase have been marked as deprecated.

DEPRECATED:

helper/validation: ValidateListUniqueStrings
helper/validation: SingleIP
helper/validation: IPRange
helper/validation: CIDRNetwork
helper/validation: ValidateJsonString
helper/validation: ValidateRegexp
helper/validation: ValidateRFC3339TimeString

Related:

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 31, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 31, 2020
@ewbankkit
Copy link
Contributor Author

$ grep ValidateListUniqueStrings aws/*.go | wc -l
0
$ grep SingleIP aws/*.go | wc -l
2
$ grep IPRange aws/*.go | wc -l
45
$ grep CIDRNetwork aws/*.go | wc -l
16
$ grep ValidateJsonString aws/*.go | wc -l
38
$ grep ValidateRegexp aws/*.go | wc -l
3
$ grep ValidateRFC3339TimeString aws/*.go | wc -l
11

@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jan 31, 2020
@bflad
Copy link
Contributor

bflad commented Feb 3, 2020

Fixing these can be covered via enabling the tfproviderlint checks: V002, V004, V005, V007, and V008. e.g.

/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_codepipeline_webhook.go:54:22: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_vpc.go:37:19: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_vpc_ipv4_cidr_block_association.go:39:19: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_route53_resolver_endpoint.go:58:22: V004: deprecated validation.SingleIP should be replaced with validation.IsIPAddress
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_route53_resolver_rule.go:79:22: V004: deprecated validation.SingleIP should be replaced with validation.IsIPAddress
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/data_source_aws_lambda_invocation.go:37:19: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_api_gateway_rest_api.go:52:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudformation_stack.go:91:19: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_dashboard.go:37:19: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_config_config_rule.go:52:19: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_config_organization_custom_rule.go:56:6: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_config_organization_managed_rule.go:56:6: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_dms_replication_task.go:63:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_dms_replication_task.go:75:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ecr_lifecycle_policy.go:30:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_elasticsearch_domain.go:61:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_emr_cluster.go:114:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_emr_cluster.go:279:26: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_emr_cluster.go:463:26: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_emr_cluster.go:588:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_emr_instance_group.go:47:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_emr_instance_group.go:63:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_emr_security_configuration.go:44:19: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_glacier_vault.go:61:19: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_glue_crawler.go:189:19: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_role.go:104:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_kms_external_key.go:79:6: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_kms_key.go:74:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_organizations_policy.go:34:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_s3_bucket.go:77:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_s3_bucket.go:143:22: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_s3_bucket_policy.go:36:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_secretsmanager_secret.go:59:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ses_identity_policy.go:43:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_sns_topic.go:70:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_sns_topic.go:81:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_sns_topic_policy.go:36:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_sns_topic_subscription.go:74:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_sns_topic_subscription.go:89:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_sqs_queue.go:94:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_sqs_queue.go:100:19: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_sqs_queue_policy.go:38:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_vpc_endpoint.go:67:23: V005: deprecated validation.ValidateJsonString should be replaced with validation.StringIsJSON
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/data_source_aws_ami.go:35:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/data_source_aws_ami_ids.go:33:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/data_source_aws_elastic_beanstalk_solution_stack.go:22:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_appsync_api_key.go:46:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ec2_capacity_reservation.go:45:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_kms_external_key.go:86:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_lambda_event_source_mapping.go:62:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_launch_template.go:302:25: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_s3_bucket_object.go:194:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_spot_fleet_request.go:343:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_spot_fleet_request.go:349:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_spot_instance_request.go:97:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_spot_instance_request.go:104:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ssm_activation.go:42:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time

bflad added a commit that referenced this issue Feb 3, 2020
Gaps in `tfproviderlint` checking are covered by the following issues:

Reference: #9950 (fix and enable AT003)
Reference: #11862 (fix and enable AT005)
Reference: #9951 (fix and enable R001)
Reference: #9952 (fix and enable R002)
Reference: #9953 (fix and enable R003)
Reference: #9954 (fix and enable R004)
Reference: #11863 (fix and enable R005)
Reference: #11864 (fix and enable R006)
Reference: #9955 (fix and enable S006)
Reference: #9956 (fix and enable S018)
Reference: #11865 (fix and enable S020)
Reference: #11866 (fix and enable S022)
Reference: #11867 (fix and enable S023)
Reference: #11868 (fix and enable S024)
Reference: #11869 (fix and enable S031)
Reference: #11870 (fix and enable S032)
Reference: #11871 (fix and enable S033)
Reference: #11872 (fix and enable V001)
Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
bflad added a commit that referenced this issue Feb 4, 2020
Gaps in `tfproviderlint` checking are covered by the following issues:

Reference: #9950 (fix and enable AT003)
Reference: #11862 (fix and enable AT005)
Reference: #9951 (fix and enable R001)
Reference: #9952 (fix and enable R002)
Reference: #9953 (fix and enable R003)
Reference: #9954 (fix and enable R004)
Reference: #11863 (fix and enable R005)
Reference: #11864 (fix and enable R006)
Reference: #9955 (fix and enable S006)
Reference: #9956 (fix and enable S018)
Reference: #11865 (fix and enable S020)
Reference: #11866 (fix and enable S022)
Reference: #11867 (fix and enable S023)
Reference: #11868 (fix and enable S024)
Reference: #11869 (fix and enable S031)
Reference: #11870 (fix and enable S032)
Reference: #11871 (fix and enable S033)
Reference: #11872 (fix and enable V001)
Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
bflad added a commit that referenced this issue Feb 19, 2020
Reference: #12074

Gaps in `tfproviderlint`/`awsproviderlint` checking are covered by the following issues:

Reference: #11888 (fix and enable AWSAT001)
Reference: #9950 (fix and enable AT003)
Reference: #11862 (fix and enable AT005)
Reference: #9951 (fix and enable R001)
Reference: #9952 (fix and enable R002)
Reference: #9953 (fix and enable R003)
Reference: #11863 (fix and enable R005)
Reference: #11864 (fix and enable R006)
Reference: #12083 (fix and enable R007, R008)
Reference: #9955 (fix and enable S006)
Reference: #9956 (fix and enable S018)
Reference: #11865 (fix and enable S020)
Reference: #11866 (fix and enable S022)
Reference: #11867 (fix and enable S023)
Reference: #11868 (fix and enable S024)
Reference: #11869 (fix and enable S031)
Reference: #11870 (fix and enable S032)
Reference: #11871 (fix and enable S033)
Reference: #11872 (fix and enable V001)
Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
bflad added a commit that referenced this issue Mar 3, 2020
Reference: #11844

Previously:

```
aws/resource_aws_codepipeline_webhook.go:54:22: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork
aws/resource_aws_vpc.go:37:19: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork
aws/resource_aws_vpc_ipv4_cidr_block_association.go:39:19: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork

aws/resource_aws_route53_resolver_endpoint.go:58:22: V004: deprecated validation.SingleIP should be replaced with validation.IsIPAddress
aws/resource_aws_route53_resolver_rule.go:79:22: V004: deprecated validation.SingleIP should be replaced with validation.IsIPAddress

aws/data_source_aws_ami.go:35:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp
aws/data_source_aws_ami_ids.go:33:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp
aws/data_source_aws_elastic_beanstalk_solution_stack.go:22:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp

aws/resource_aws_appsync_api_key.go:46:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_ec2_capacity_reservation.go:45:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_kms_external_key.go:86:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_lambda_event_source_mapping.go:62:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_launch_template.go:320:25: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_s3_bucket_object.go:193:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_fleet_request.go:343:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_fleet_request.go:349:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_instance_request.go:104:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_instance_request.go:97:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_ssm_activation.go:42:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
```

Output from acceptance testing:

```
--- PASS: TestAccAWSAmiDataSource_instanceStore (14.77s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (18.63s)
--- PASS: TestAccAWSAmiDataSource_natInstance (15.86s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (17.85s)

--- PASS: TestAccDataSourceAwsAmiIds_basic (15.83s)
--- PASS: TestAccDataSourceAwsAmiIds_sorted (31.07s)

--- PASS: TestAccAWSElasticBeanstalkSolutionStackDataSource (13.74s)

--- PASS: TestAccAWSAppsyncApiKey_basic (19.11s)
--- PASS: TestAccAWSAppsyncApiKey_Description (26.75s)
--- PASS: TestAccAWSAppsyncApiKey_Expires (26.03s)

--- PASS: TestAccAWSCodePipelineWebhook_basic (45.87s)
--- PASS: TestAccAWSCodePipelineWebhook_ipAuth (44.09s)
--- PASS: TestAccAWSCodePipelineWebhook_tags (92.65s)
--- PASS: TestAccAWSCodePipelineWebhook_unauthenticated (45.40s)
--- PASS: TestAccAWSCodePipelineWebhook_UpdateAuthenticationConfiguration_SecretToken (63.24s)

--- PASS: TestAccAWSEc2CapacityReservation_basic (19.18s)
--- PASS: TestAccAWSEc2CapacityReservation_ebsOptimized (18.24s)
--- PASS: TestAccAWSEc2CapacityReservation_endDate (30.99s)
--- PASS: TestAccAWSEc2CapacityReservation_endDateType (44.58s)
--- PASS: TestAccAWSEc2CapacityReservation_ephemeralStorage (18.73s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceCount (32.83s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceMatchCriteria (18.71s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceType (32.72s)
--- PASS: TestAccAWSEc2CapacityReservation_tags (45.51s)

--- PASS: TestAccAWSKmsExternalKey_basic (41.14s)
--- PASS: TestAccAWSKmsExternalKey_DeletionWindowInDays (52.45s)
--- PASS: TestAccAWSKmsExternalKey_Description (52.48s)
--- PASS: TestAccAWSKmsExternalKey_disappears (33.53s)
--- PASS: TestAccAWSKmsExternalKey_Enabled (308.60s)
--- PASS: TestAccAWSKmsExternalKey_KeyMaterialBase64 (145.65s)
--- PASS: TestAccAWSKmsExternalKey_Policy (53.09s)
--- PASS: TestAccAWSKmsExternalKey_Tags (65.26s)
--- PASS: TestAccAWSKmsExternalKey_ValidTo (191.46s)

--- PASS: TestAccAWSLambdaEventSourceMapping_BatchWindow (85.38s)
--- PASS: TestAccAWSLambdaEventSourceMapping_BisectBatch (83.25s)
--- PASS: TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected (86.33s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (84.71s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_disappears (70.37s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize (84.85s)
--- PASS: TestAccAWSLambdaEventSourceMapping_KinesisDestinationConfig (87.03s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRecordAgeInSeconds (83.44s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRetryAttempts (83.57s)
--- PASS: TestAccAWSLambdaEventSourceMapping_ParallelizationFactor (84.20s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_basic (91.05s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName (38.73s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (132.14s)
--- PASS: TestAccAWSLambdaEventSourceMapping_StartingPositionTimestamp (70.89s)

--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (81.29s)
--- PASS: TestAccAWSLaunchTemplate_basic (16.75s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (41.98s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (48.44s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (19.58s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (20.22s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (16.28s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (16.50s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (19.34s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (17.09s)
--- PASS: TestAccAWSLaunchTemplate_data (17.93s)
--- PASS: TestAccAWSLaunchTemplate_description (31.55s)
--- PASS: TestAccAWSLaunchTemplate_disappears (12.52s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (61.86s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (30.31s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (14.70s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (50.72s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (21.67s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (36.47s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (16.76s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (17.95s)
--- PASS: TestAccAWSLaunchTemplate_tags (34.53s)
--- PASS: TestAccAWSLaunchTemplate_update (79.77s)

--- PASS: TestAccAwsRoute53ResolverEndpoint_basicInbound (97.11s)
--- PASS: TestAccAwsRoute53ResolverEndpoint_updateOutbound (394.08s)

--- PASS: TestAccAwsRoute53ResolverRule_basic (41.82s)
--- PASS: TestAccAwsRoute53ResolverRule_forward (297.20s)
--- PASS: TestAccAwsRoute53ResolverRule_forwardEndpointRecreate (430.76s)
--- PASS: TestAccAwsRoute53ResolverRule_tags (69.62s)
--- PASS: TestAccAwsRoute53ResolverRule_updateName (67.71s)

--- PASS: TestAccAWSS3BucketObject_acl (76.63s)
--- PASS: TestAccAWSS3BucketObject_content (35.37s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (36.20s)
--- PASS: TestAccAWSS3BucketObject_empty (32.32s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (34.91s)
--- PASS: TestAccAWSS3BucketObject_kms (56.13s)
--- PASS: TestAccAWSS3BucketObject_metadata (74.02s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (1.31s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (77.38s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (58.46s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (79.33s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (99.87s)
--- PASS: TestAccAWSS3BucketObject_source (31.86s)
--- PASS: TestAccAWSS3BucketObject_sse (34.55s)
--- PASS: TestAccAWSS3BucketObject_storageClass (116.76s)
--- PASS: TestAccAWSS3BucketObject_tags (101.60s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (99.58s)
--- PASS: TestAccAWSS3BucketObject_updates (55.60s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (57.91s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (54.93s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (63.40s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (38.99s)

--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (285.86s)
--- PASS: TestAccAWSSpotFleetRequest_basic (412.16s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (525.75s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (266.75s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (295.24s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (387.80s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (276.65s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (191.89s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (182.38s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (274.39s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (276.68s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (218.95s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (265.21s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (288.81s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (228.79s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (255.04s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (61.33s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (543.75s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (883.50s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (368.32s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (266.91s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (262.01s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (295.13s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (403.21s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (275.44s)

--- PASS: TestAccAWSSpotInstanceRequest_basic (106.05s)
--- PASS: TestAccAWSSpotInstanceRequest_getPasswordData (261.45s)
--- PASS: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (100.98s)
--- PASS: TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress (143.21s)
--- PASS: TestAccAWSSpotInstanceRequest_validUntil (116.82s)
--- PASS: TestAccAWSSpotInstanceRequest_vpc (122.18s)
--- PASS: TestAccAWSSpotInstanceRequest_withBlockDuration (95.86s)
--- PASS: TestAccAWSSpotInstanceRequest_withLaunchGroup (85.79s)
--- PASS: TestAccAWSSpotInstanceRequest_withoutSpotPrice (117.04s)

--- PASS: TestAccAWSSSMActivation_basic (34.84s)
--- PASS: TestAccAWSSSMActivation_disappears (27.99s)
--- PASS: TestAccAWSSSMActivation_update (39.53s)

--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (75.46s)
--- PASS: TestAccAWSVpc_basic (30.07s)
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (31.61s)
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (34.03s)
--- PASS: TestAccAWSVpc_classiclinkOptionSet (30.84s)
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (26.30s)
--- PASS: TestAccAWSVpc_DisabledDnsSupport (31.74s)
--- PASS: TestAccAWSVpc_disappears (16.57s)
--- PASS: TestAccAWSVpc_ignoreTags (52.00s)
--- PASS: TestAccAWSVpc_tags (52.71s)
--- PASS: TestAccAWSVpc_Tenancy (76.46s)
--- PASS: TestAccAWSVpc_update (45.63s)

--- PASS: TestAccAwsVpcIpv4CidrBlockAssociation_basic (53.59s)
```
@bflad bflad self-assigned this Mar 3, 2020
bflad added a commit that referenced this issue Mar 10, 2020
Reference: #12074

Gaps in `tfproviderlint`/`awsproviderlint` checking are covered by the following issues:

Reference: #11888 (fix and enable AWSAT001)
Reference: #9950 (fix and enable AT003)
Reference: #11862 (fix and enable AT005)
Reference: #9951 (fix and enable R001)
Reference: #9952 (fix and enable R002)
Reference: #9953 (fix and enable R003)
Reference: #11863 (fix and enable R005)
Reference: #11864 (fix and enable R006)
Reference: #12083 (fix and enable R007, R008)
Reference: #9955 (fix and enable S006)
Reference: #9956 (fix and enable S018)
Reference: #11865 (fix and enable S020)
Reference: #11866 (fix and enable S022)
Reference: #11867 (fix and enable S023)
Reference: #11868 (fix and enable S024)
Reference: #11869 (fix and enable S031)
Reference: #11870 (fix and enable S032)
Reference: #11871 (fix and enable S033)
Reference: #11872 (fix and enable V001)
Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
bflad added a commit that referenced this issue Mar 10, 2020
…12233)

Reference: #11844

Previously:

```
aws/resource_aws_codepipeline_webhook.go:54:22: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork
aws/resource_aws_vpc.go:37:19: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork
aws/resource_aws_vpc_ipv4_cidr_block_association.go:39:19: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork

aws/resource_aws_route53_resolver_endpoint.go:58:22: V004: deprecated validation.SingleIP should be replaced with validation.IsIPAddress
aws/resource_aws_route53_resolver_rule.go:79:22: V004: deprecated validation.SingleIP should be replaced with validation.IsIPAddress

aws/data_source_aws_ami.go:35:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp
aws/data_source_aws_ami_ids.go:33:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp
aws/data_source_aws_elastic_beanstalk_solution_stack.go:22:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp

aws/resource_aws_appsync_api_key.go:46:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_ec2_capacity_reservation.go:45:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_kms_external_key.go:86:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_lambda_event_source_mapping.go:62:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_launch_template.go:320:25: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_s3_bucket_object.go:193:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_fleet_request.go:343:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_fleet_request.go:349:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_instance_request.go:104:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_instance_request.go:97:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_ssm_activation.go:42:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
```

Output from acceptance testing:

```
--- PASS: TestAccAWSAmiDataSource_instanceStore (14.77s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (18.63s)
--- PASS: TestAccAWSAmiDataSource_natInstance (15.86s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (17.85s)

--- PASS: TestAccDataSourceAwsAmiIds_basic (15.83s)
--- PASS: TestAccDataSourceAwsAmiIds_sorted (31.07s)

--- PASS: TestAccAWSElasticBeanstalkSolutionStackDataSource (13.74s)

--- PASS: TestAccAWSAppsyncApiKey_basic (19.11s)
--- PASS: TestAccAWSAppsyncApiKey_Description (26.75s)
--- PASS: TestAccAWSAppsyncApiKey_Expires (26.03s)

--- PASS: TestAccAWSCodePipelineWebhook_basic (45.87s)
--- PASS: TestAccAWSCodePipelineWebhook_ipAuth (44.09s)
--- PASS: TestAccAWSCodePipelineWebhook_tags (92.65s)
--- PASS: TestAccAWSCodePipelineWebhook_unauthenticated (45.40s)
--- PASS: TestAccAWSCodePipelineWebhook_UpdateAuthenticationConfiguration_SecretToken (63.24s)

--- PASS: TestAccAWSEc2CapacityReservation_basic (19.18s)
--- PASS: TestAccAWSEc2CapacityReservation_ebsOptimized (18.24s)
--- PASS: TestAccAWSEc2CapacityReservation_endDate (30.99s)
--- PASS: TestAccAWSEc2CapacityReservation_endDateType (44.58s)
--- PASS: TestAccAWSEc2CapacityReservation_ephemeralStorage (18.73s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceCount (32.83s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceMatchCriteria (18.71s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceType (32.72s)
--- PASS: TestAccAWSEc2CapacityReservation_tags (45.51s)

--- PASS: TestAccAWSKmsExternalKey_basic (41.14s)
--- PASS: TestAccAWSKmsExternalKey_DeletionWindowInDays (52.45s)
--- PASS: TestAccAWSKmsExternalKey_Description (52.48s)
--- PASS: TestAccAWSKmsExternalKey_disappears (33.53s)
--- PASS: TestAccAWSKmsExternalKey_Enabled (308.60s)
--- PASS: TestAccAWSKmsExternalKey_KeyMaterialBase64 (145.65s)
--- PASS: TestAccAWSKmsExternalKey_Policy (53.09s)
--- PASS: TestAccAWSKmsExternalKey_Tags (65.26s)
--- PASS: TestAccAWSKmsExternalKey_ValidTo (191.46s)

--- PASS: TestAccAWSLambdaEventSourceMapping_BatchWindow (85.38s)
--- PASS: TestAccAWSLambdaEventSourceMapping_BisectBatch (83.25s)
--- PASS: TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected (86.33s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (84.71s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_disappears (70.37s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize (84.85s)
--- PASS: TestAccAWSLambdaEventSourceMapping_KinesisDestinationConfig (87.03s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRecordAgeInSeconds (83.44s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRetryAttempts (83.57s)
--- PASS: TestAccAWSLambdaEventSourceMapping_ParallelizationFactor (84.20s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_basic (91.05s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName (38.73s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (132.14s)
--- PASS: TestAccAWSLambdaEventSourceMapping_StartingPositionTimestamp (70.89s)

--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (81.29s)
--- PASS: TestAccAWSLaunchTemplate_basic (16.75s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (41.98s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (48.44s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (19.58s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (20.22s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (16.28s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (16.50s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (19.34s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (17.09s)
--- PASS: TestAccAWSLaunchTemplate_data (17.93s)
--- PASS: TestAccAWSLaunchTemplate_description (31.55s)
--- PASS: TestAccAWSLaunchTemplate_disappears (12.52s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (61.86s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (30.31s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (14.70s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (50.72s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (21.67s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (36.47s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (16.76s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (17.95s)
--- PASS: TestAccAWSLaunchTemplate_tags (34.53s)
--- PASS: TestAccAWSLaunchTemplate_update (79.77s)

--- PASS: TestAccAwsRoute53ResolverEndpoint_basicInbound (97.11s)
--- PASS: TestAccAwsRoute53ResolverEndpoint_updateOutbound (394.08s)

--- PASS: TestAccAwsRoute53ResolverRule_basic (41.82s)
--- PASS: TestAccAwsRoute53ResolverRule_forward (297.20s)
--- PASS: TestAccAwsRoute53ResolverRule_forwardEndpointRecreate (430.76s)
--- PASS: TestAccAwsRoute53ResolverRule_tags (69.62s)
--- PASS: TestAccAwsRoute53ResolverRule_updateName (67.71s)

--- PASS: TestAccAWSS3BucketObject_acl (76.63s)
--- PASS: TestAccAWSS3BucketObject_content (35.37s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (36.20s)
--- PASS: TestAccAWSS3BucketObject_empty (32.32s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (34.91s)
--- PASS: TestAccAWSS3BucketObject_kms (56.13s)
--- PASS: TestAccAWSS3BucketObject_metadata (74.02s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (1.31s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (77.38s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (58.46s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (79.33s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (99.87s)
--- PASS: TestAccAWSS3BucketObject_source (31.86s)
--- PASS: TestAccAWSS3BucketObject_sse (34.55s)
--- PASS: TestAccAWSS3BucketObject_storageClass (116.76s)
--- PASS: TestAccAWSS3BucketObject_tags (101.60s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (99.58s)
--- PASS: TestAccAWSS3BucketObject_updates (55.60s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (57.91s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (54.93s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (63.40s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (38.99s)

--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (285.86s)
--- PASS: TestAccAWSSpotFleetRequest_basic (412.16s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (525.75s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (266.75s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (295.24s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (387.80s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (276.65s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (191.89s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (182.38s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (274.39s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (276.68s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (218.95s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (265.21s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (288.81s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (228.79s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (255.04s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (61.33s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (543.75s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (883.50s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (368.32s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (266.91s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (262.01s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (295.13s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (403.21s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (275.44s)

--- PASS: TestAccAWSSpotInstanceRequest_basic (106.05s)
--- PASS: TestAccAWSSpotInstanceRequest_getPasswordData (261.45s)
--- PASS: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (100.98s)
--- PASS: TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress (143.21s)
--- PASS: TestAccAWSSpotInstanceRequest_validUntil (116.82s)
--- PASS: TestAccAWSSpotInstanceRequest_vpc (122.18s)
--- PASS: TestAccAWSSpotInstanceRequest_withBlockDuration (95.86s)
--- PASS: TestAccAWSSpotInstanceRequest_withLaunchGroup (85.79s)
--- PASS: TestAccAWSSpotInstanceRequest_withoutSpotPrice (117.04s)

--- PASS: TestAccAWSSSMActivation_basic (34.84s)
--- PASS: TestAccAWSSSMActivation_disappears (27.99s)
--- PASS: TestAccAWSSSMActivation_update (39.53s)

--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (75.46s)
--- PASS: TestAccAWSVpc_basic (30.07s)
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (31.61s)
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (34.03s)
--- PASS: TestAccAWSVpc_classiclinkOptionSet (30.84s)
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (26.30s)
--- PASS: TestAccAWSVpc_DisabledDnsSupport (31.74s)
--- PASS: TestAccAWSVpc_disappears (16.57s)
--- PASS: TestAccAWSVpc_ignoreTags (52.00s)
--- PASS: TestAccAWSVpc_tags (52.71s)
--- PASS: TestAccAWSVpc_Tenancy (76.46s)
--- PASS: TestAccAWSVpc_update (45.63s)

--- PASS: TestAccAwsVpcIpv4CidrBlockAssociation_basic (53.59s)
```
bflad added a commit that referenced this issue Mar 13, 2020
…ction

Reference: #11844
Reference: #12087

Output from acceptance testing:

```
Pending in TeamCity
```
bflad added a commit that referenced this issue Mar 17, 2020
…ction

Reference: #11844
Reference: #12087

Output from acceptance testing:

```
--- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (218.84s)
--- PASS: TestAccAWSAPIGatewayRestApi_basic (246.20s)
--- PASS: TestAccAWSAPIGatewayRestApi_disappears (460.53s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (285.90s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (467.53s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (154.73s)
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (62.10s)
--- PASS: TestAccAWSAPIGatewayRestApi_policy (199.88s)
--- PASS: TestAccAWSAPIGatewayRestApi_tags (402.12s)

--- PASS: TestAccAWSCloudFormationStack_allAttributes (70.67s)
--- PASS: TestAccAWSCloudFormationStack_basic (59.18s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (61.62s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (61.56s)
--- PASS: TestAccAWSCloudFormationStack_defaultParams (58.83s)
--- PASS: TestAccAWSCloudFormationStack_disappears (62.00s)
--- PASS: TestAccAWSCloudFormationStack_withParams (112.25s)
--- PASS: TestAccAWSCloudFormationStack_withTransform (41.95s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (246.31s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (70.68s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (64.80s)
--- PASS: TestAccAWSCloudFormationStack_yaml (60.20s)

--- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (29.26s)
--- PASS: TestAccAWSCloudFormationStackSet_basic (16.03s)
--- PASS: TestAccAWSCloudFormationStackSet_Description (29.27s)
--- PASS: TestAccAWSCloudFormationStackSet_disappears (12.91s)
--- PASS: TestAccAWSCloudFormationStackSet_ExecutionRoleName (29.08s)
--- PASS: TestAccAWSCloudFormationStackSet_Name (24.91s)
--- PASS: TestAccAWSCloudFormationStackSet_Parameters (56.43s)
--- PASS: TestAccAWSCloudFormationStackSet_Tags (57.84s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateBody (29.33s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (30.95s)

--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (144.36s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (136.49s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (240.59s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (163.82s)

--- PASS: TestAccAWSCloudWatchDashboard_basic (9.22s)
--- PASS: TestAccAWSCloudWatchDashboard_update (17.73s)
--- PASS: TestAccAWSCloudWatchDashboard_updateName (16.23s)

--- PASS: TestAccAWSEcrLifecyclePolicy_basic (8.19s)

--- PASS: TestAccAWSElasticSearchDomain_basic (968.64s)
--- PASS: TestAccAWSElasticSearchDomain_ClusterConfig_ZoneAwarenessConfig (5693.29s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (1688.64s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (1732.49s)
--- PASS: TestAccAWSElasticSearchDomain_complex (1070.15s)
--- PASS: TestAccAWSElasticSearchDomain_duplicate (750.80s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key (807.91s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key (982.53s)
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (2248.88s)
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (1860.12s)
--- PASS: TestAccAWSElasticSearchDomain_NodeToNodeEncryption (1244.68s)
--- PASS: TestAccAWSElasticSearchDomain_policy (1478.83s)
--- PASS: TestAccAWSElasticSearchDomain_RequireHTTPS (2255.42s)
--- PASS: TestAccAWSElasticSearchDomain_tags (1705.94s)
--- PASS: TestAccAWSElasticSearchDomain_update (2530.76s)
--- PASS: TestAccAWSElasticSearchDomain_update_version (3559.61s)
--- PASS: TestAccAWSElasticSearchDomain_update_volume_type (3442.15s)
--- PASS: TestAccAWSElasticSearchDomain_v23 (1098.40s)
--- PASS: TestAccAWSElasticSearchDomain_vpc (1306.48s)
--- PASS: TestAccAWSElasticSearchDomain_vpc_update (3239.89s)
--- PASS: TestAccAWSElasticSearchDomain_withDedicatedMaster (3452.05s)

--- PASS: TestAccAWSElasticSearchDomainPolicy_basic (1600.78s)

--- PASS: TestAccAWSEMRCluster_additionalInfo (509.02s)
--- PASS: TestAccAWSEMRCluster_basic (428.91s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (445.41s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (639.64s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (478.82s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (982.01s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (488.56s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (825.23s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Migration_CoreInstanceType (417.46s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Migration_InstanceGroup (386.07s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (799.01s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (481.47s)
--- PASS: TestAccAWSEMRCluster_disappears (377.84s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (729.59s)
--- PASS: TestAccAWSEMRCluster_instance_group (497.55s)
--- PASS: TestAccAWSEMRCluster_instance_group_EBSVolumeType_st1 (520.38s)
--- PASS: TestAccAWSEMRCluster_instance_group_names (596.00s)
--- PASS: TestAccAWSEMRCluster_instance_group_update (493.37s)
--- PASS: TestAccAWSEMRCluster_keepJob (451.47s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (433.56s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (746.72s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1281.57s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (778.11s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Migration_InstanceGroup (483.64s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Migration_MasterInstanceType (425.17s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (850.44s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (858.22s)
--- PASS: TestAccAWSEMRCluster_s3Logging (508.32s)
--- PASS: TestAccAWSEMRCluster_security_config (576.85s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (586.06s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (395.29s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (855.25s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (454.02s)
--- PASS: TestAccAWSEMRCluster_tags (814.84s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (446.75s)
--- PASS: TestAccAWSEMRCluster_updateAutoScalingPolicy (494.30s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (899.11s)

--- PASS: TestAccAWSEMRInstanceGroup_AutoScalingPolicy (853.38s)
--- PASS: TestAccAWSEMRInstanceGroup_basic (794.28s)
--- PASS: TestAccAWSEMRInstanceGroup_BidPrice (1390.82s)
--- PASS: TestAccAWSEMRInstanceGroup_ConfigurationsJson (842.20s)
--- PASS: TestAccAWSEMRInstanceGroup_EbsConfig_EbsOptimized (1106.71s)
--- PASS: TestAccAWSEMRInstanceGroup_EmrClusterDisappears (679.63s)
--- PASS: TestAccAWSEMRInstanceGroup_InstanceCount (1403.60s)

--- PASS: TestAccAWSEmrSecurityConfiguration_basic (8.76s)

--- PASS: TestAccAWSGlacierVault_basic (8.63s)
--- PASS: TestAccAWSGlacierVault_full (9.14s)
--- PASS: TestAccAWSGlacierVault_RemoveNotifications (14.43s)

--- PASS: TestAccAWSGlacierVaultLock_basic (9.82s)
--- PASS: TestAccAWSGlacierVaultLock_CompleteLock (10.20s)

--- PASS: TestAccAWSGlueCrawler_CatalogTarget (38.61s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget_Multiple (47.35s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (36.80s)
--- PASS: TestAccAWSGlueCrawler_Configuration (37.05s)
--- PASS: TestAccAWSGlueCrawler_Description (37.00s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (30.29s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (38.50s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (38.06s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (46.36s)
--- PASS: TestAccAWSGlueCrawler_recreates (35.97s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (21.88s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (20.64s)
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (28.52s)
--- PASS: TestAccAWSGlueCrawler_S3Target (37.82s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (29.77s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (45.00s)
--- PASS: TestAccAWSGlueCrawler_Schedule (38.24s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (37.62s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (37.94s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (37.14s)
--- PASS: TestAccAWSGlueCrawler_Tags (46.21s)

--- PASS: TestAccAWSIAMRole_badJSON (1.15s)
--- PASS: TestAccAWSIAMRole_basic (10.76s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (23.81s)
--- PASS: TestAccAWSIAMRole_disappears (7.55s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (14.40s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (18.56s)
--- PASS: TestAccAWSIAMRole_namePrefix (10.93s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (36.79s)
--- PASS: TestAccAWSIAMRole_tags (17.40s)
--- PASS: TestAccAWSIAMRole_testNameChange (24.14s)

--- PASS: TestAccAWSIAMRolePolicy_basic (19.89s)
--- PASS: TestAccAWSIAMRolePolicy_disappears (10.60s)
--- PASS: TestAccAWSIAMRolePolicy_generatedName (19.39s)
--- PASS: TestAccAWSIAMRolePolicy_invalidJSON (1.07s)
--- PASS: TestAccAWSIAMRolePolicy_namePrefix (19.99s)
--- PASS: TestAccAWSIAMRolePolicy_Policy_InvalidResource (6.41s)

--- PASS: TestAccAWSKmsExternalKey_basic (26.08s)
--- PASS: TestAccAWSKmsExternalKey_DeletionWindowInDays (31.27s)
--- PASS: TestAccAWSKmsExternalKey_Description (30.91s)
--- PASS: TestAccAWSKmsExternalKey_disappears (24.43s)
--- PASS: TestAccAWSKmsExternalKey_Enabled (155.55s)
--- PASS: TestAccAWSKmsExternalKey_KeyMaterialBase64 (152.20s)
--- PASS: TestAccAWSKmsExternalKey_Tags (36.09s)
--- PASS: TestAccAWSKmsExternalKey_ValidTo (134.44s)

--- PASS: TestAccAWSKmsKey_asymmetricKey (25.37s)
--- PASS: TestAccAWSKmsKey_basic (26.63s)
--- PASS: TestAccAWSKmsKey_disappears (6.53s)
--- PASS: TestAccAWSKmsKey_isEnabled (252.23s)
--- PASS: TestAccAWSKmsKey_policy (31.77s)
--- PASS: TestAccAWSKmsKey_tags (32.26s)

--- PASS: TestAccAWSS3Bucket_acceleration (21.85s)
--- PASS: TestAccAWSS3Bucket_AclToGrant (18.23s)
--- PASS: TestAccAWSS3Bucket_basic (11.21s)
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (11.03s)
--- PASS: TestAccAWSS3Bucket_Cors_Delete (11.79s)
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (13.19s)
--- PASS: TestAccAWSS3Bucket_Cors_Update (19.59s)
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (18.47s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (12.39s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (30.78s)
--- PASS: TestAccAWSS3Bucket_forceDestroy (11.09s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes (9.94s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled (11.26s)
--- PASS: TestAccAWSS3Bucket_generatedName (11.85s)
--- PASS: TestAccAWSS3Bucket_GrantToAcl (18.10s)
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (19.81s)
--- PASS: TestAccAWSS3Bucket_Logging (13.72s)
--- PASS: TestAccAWSS3Bucket_namePrefix (11.57s)
--- PASS: TestAccAWSS3Bucket_objectLock (18.09s)
--- PASS: TestAccAWSS3Bucket_Policy (27.62s)
--- PASS: TestAccAWSS3Bucket_region (11.65s)
--- PASS: TestAccAWSS3Bucket_Replication (129.48s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (87.12s)
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (24.10s)
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (112.93s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (40.15s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (40.30s)
--- PASS: TestAccAWSS3Bucket_RequestPayer (19.03s)
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (7.66s)
--- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (33.35s)
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (79.48s)
--- PASS: TestAccAWSS3Bucket_UpdateAcl (19.13s)
--- PASS: TestAccAWSS3Bucket_UpdateGrant (26.93s)
--- PASS: TestAccAWSS3Bucket_Versioning (26.43s)
--- PASS: TestAccAWSS3Bucket_Website_Simple (25.61s)
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (24.99s)
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (19.05s)
--- PASS: TestAccAWSS3MultiBucket_withTags (13.95s)

--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_basic (11.63s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_removed (16.49s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_updateBasic (25.76s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Empty (1.07s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_MultipleTags (17.35s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Prefix (18.13s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_PrefixAndTags (17.55s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Remove (18.44s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_SingleTag (17.35s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Default (11.24s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Empty (1.00s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Full (11.93s)

--- PASS: TestAccAWSS3BucketInventory_basic (12.77s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSEKMS (29.01s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSES3 (11.71s)

--- PASS: TestAccAWSS3BucketMetric_basic (10.78s)
--- PASS: TestAccAWSS3BucketMetric_WithEmptyFilter (9.68s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterMultipleTags (17.06s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefix (17.44s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags (16.44s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag (16.90s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterSingleTag (17.44s)

--- PASS: TestAccAWSS3BucketNotification_LambdaFunction (33.03s)
--- PASS: TestAccAWSS3BucketNotification_LambdaFunction_LambdaFunctionArn_Alias (32.74s)
--- PASS: TestAccAWSS3BucketNotification_Queue (12.90s)
--- PASS: TestAccAWSS3BucketNotification_Topic (12.99s)
--- PASS: TestAccAWSS3BucketNotification_Topic_Multiple (13.95s)
--- PASS: TestAccAWSS3BucketNotification_update (19.63s)

--- PASS: TestAccAWSS3BucketObject_acl (24.41s)
--- PASS: TestAccAWSS3BucketObject_content (9.92s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (10.27s)
--- PASS: TestAccAWSS3BucketObject_empty (10.26s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (10.84s)
--- PASS: TestAccAWSS3BucketObject_kms (29.19s)
--- PASS: TestAccAWSS3BucketObject_metadata (23.93s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (1.36s)
--- PASS: TestAccAWSS3BucketObject_NonVersioned (10.81s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (24.84s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (17.18s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (25.37s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (30.59s)
--- PASS: TestAccAWSS3BucketObject_source (10.15s)
--- PASS: TestAccAWSS3BucketObject_sse (11.86s)
--- PASS: TestAccAWSS3BucketObject_storageClass (37.17s)
--- PASS: TestAccAWSS3BucketObject_tags (30.42s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (31.04s)
--- PASS: TestAccAWSS3BucketObject_updates (17.59s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (17.71s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (17.64s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (19.48s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (10.76s)

--- PASS: TestAccAWSS3BucketPolicy_basic (12.65s)
--- PASS: TestAccAWSS3BucketPolicy_policyUpdate (19.53s)

--- PASS: TestAccAWSS3BucketPublicAccessBlock_basic (12.28s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_BlockPublicAcls (25.82s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_BlockPublicPolicy (25.48s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_bucketDisappears (8.80s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_disappears (10.79s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_IgnorePublicAcls (25.40s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_RestrictPublicBuckets (25.45s)

--- PASS: TestAccAwsSecretsManagerSecret_Basic (9.27s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (13.90s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (32.67s)
--- PASS: TestAccAwsSecretsManagerSecret_policy (7.35s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (49.94s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (44.62s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (38.99s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (23.26s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (9.10s)

--- PASS: TestAccAwsSecretsManagerSecretVersion_Base64Binary (8.89s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_BasicString (8.47s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_VersionStages (19.44s)

--- PASS: TestAccAWSSESIdentityPolicy_basic (9.48s)
--- PASS: TestAccAWSSESIdentityPolicy_Identity_Email (9.53s)
--- PASS: TestAccAWSSESIdentityPolicy_Policy (15.16s)

--- PASS: TestAccAWSSNSTopic_basic (8.57s)
--- PASS: TestAccAWSSNSTopic_deliveryStatus (23.89s)
--- PASS: TestAccAWSSNSTopic_encryption (14.20s)
--- PASS: TestAccAWSSNSTopic_name (9.16s)
--- PASS: TestAccAWSSNSTopic_namePrefix (8.80s)
--- PASS: TestAccAWSSNSTopic_policy (8.73s)
--- PASS: TestAccAWSSNSTopic_tags (20.13s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (9.00s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (125.13s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (25.72s)

--- PASS: TestAccAWSSNSTopicPolicy_basic (9.30s)

--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (35.16s)
--- PASS: TestAccAWSSNSTopicSubscription_basic (9.19s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (20.42s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (20.10s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (20.85s)

--- PASS: TestAccAWSSQSQueue_basic (20.16s)
--- PASS: TestAccAWSSQSQueue_Encryption (7.99s)
--- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (3.66s)
--- PASS: TestAccAWSSQSQueue_FIFO (8.56s)
--- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (3.85s)
--- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (8.58s)
--- PASS: TestAccAWSSQSQueue_namePrefix (9.20s)
--- PASS: TestAccAWSSQSQueue_namePrefix_fifo (8.69s)
--- PASS: TestAccAWSSQSQueue_policy (9.82s)
--- PASS: TestAccAWSSQSQueue_Policybasic (9.64s)
--- PASS: TestAccAWSSQSQueue_queueDeletedRecently (79.37s)
--- PASS: TestAccAWSSQSQueue_redrivePolicy (9.59s)
--- PASS: TestAccAWSSQSQueue_tags (19.91s)

--- PASS: TestAccAWSSQSQueuePolicy_basic (8.76s)

--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (21.12s)
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (34.24s)
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicyAndTags (39.01s)
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (101.25s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSService (270.04s)
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (344.60s)
--- PASS: TestAccAWSVpcEndpoint_removed (15.31s)

--- PASS: TestAccAWSVpcEndpointConnectionNotification_basic (250.06s)

--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (22.18s)

--- PASS: TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags (248.90s)
--- PASS: TestAccAWSVpcEndpointService_basic (245.68s)
--- PASS: TestAccAWSVpcEndpointService_removed (249.43s)
--- PASS: TestAccAWSVpcEndpointServiceAllowedPrincipal_basic (217.69s)

--- PASS: TestAccAWSVpcEndpointSubnetAssociation_basic (254.18s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_multiple (587.43s)

--- PASS: TestAccDataSourceAwsLambdaInvocation_basic (37.09s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_complex (37.57s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_qualifier (36.15s)
```
bflad added a commit that referenced this issue Apr 28, 2020
…teJsonString with validation.StringIsJSON

Reference: #11844
Reference: #12087

Output from acceptance testing:

```
--- PASS: TestAccAWSAPIGatewayV2Model_disappears (18.58s)
--- PASS: TestAccAWSAPIGatewayV2Model_basic (20.32s)
--- PASS: TestAccAWSAPIGatewayV2Model_AllAttributes (46.23s)
```
@bflad bflad added this to the v2.60.0 milestone Apr 28, 2020
bflad added a commit that referenced this issue Apr 28, 2020
…ction (#12378)

* provider: Replace deprecated helper/validation.ValidateJsonString function

Reference: #11844
Reference: #12087

Output from acceptance testing:

```
--- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (218.84s)
--- PASS: TestAccAWSAPIGatewayRestApi_basic (246.20s)
--- PASS: TestAccAWSAPIGatewayRestApi_disappears (460.53s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (285.90s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (467.53s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (154.73s)
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (62.10s)
--- PASS: TestAccAWSAPIGatewayRestApi_policy (199.88s)
--- PASS: TestAccAWSAPIGatewayRestApi_tags (402.12s)

--- PASS: TestAccAWSCloudFormationStack_allAttributes (70.67s)
--- PASS: TestAccAWSCloudFormationStack_basic (59.18s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (61.62s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (61.56s)
--- PASS: TestAccAWSCloudFormationStack_defaultParams (58.83s)
--- PASS: TestAccAWSCloudFormationStack_disappears (62.00s)
--- PASS: TestAccAWSCloudFormationStack_withParams (112.25s)
--- PASS: TestAccAWSCloudFormationStack_withTransform (41.95s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (246.31s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (70.68s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (64.80s)
--- PASS: TestAccAWSCloudFormationStack_yaml (60.20s)

--- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (29.26s)
--- PASS: TestAccAWSCloudFormationStackSet_basic (16.03s)
--- PASS: TestAccAWSCloudFormationStackSet_Description (29.27s)
--- PASS: TestAccAWSCloudFormationStackSet_disappears (12.91s)
--- PASS: TestAccAWSCloudFormationStackSet_ExecutionRoleName (29.08s)
--- PASS: TestAccAWSCloudFormationStackSet_Name (24.91s)
--- PASS: TestAccAWSCloudFormationStackSet_Parameters (56.43s)
--- PASS: TestAccAWSCloudFormationStackSet_Tags (57.84s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateBody (29.33s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (30.95s)

--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (144.36s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (136.49s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (240.59s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (163.82s)

--- PASS: TestAccAWSCloudWatchDashboard_basic (9.22s)
--- PASS: TestAccAWSCloudWatchDashboard_update (17.73s)
--- PASS: TestAccAWSCloudWatchDashboard_updateName (16.23s)

--- PASS: TestAccAWSEcrLifecyclePolicy_basic (8.19s)

--- PASS: TestAccAWSElasticSearchDomain_basic (968.64s)
--- PASS: TestAccAWSElasticSearchDomain_ClusterConfig_ZoneAwarenessConfig (5693.29s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (1688.64s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (1732.49s)
--- PASS: TestAccAWSElasticSearchDomain_complex (1070.15s)
--- PASS: TestAccAWSElasticSearchDomain_duplicate (750.80s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key (807.91s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key (982.53s)
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (2248.88s)
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (1860.12s)
--- PASS: TestAccAWSElasticSearchDomain_NodeToNodeEncryption (1244.68s)
--- PASS: TestAccAWSElasticSearchDomain_policy (1478.83s)
--- PASS: TestAccAWSElasticSearchDomain_RequireHTTPS (2255.42s)
--- PASS: TestAccAWSElasticSearchDomain_tags (1705.94s)
--- PASS: TestAccAWSElasticSearchDomain_update (2530.76s)
--- PASS: TestAccAWSElasticSearchDomain_update_version (3559.61s)
--- PASS: TestAccAWSElasticSearchDomain_update_volume_type (3442.15s)
--- PASS: TestAccAWSElasticSearchDomain_v23 (1098.40s)
--- PASS: TestAccAWSElasticSearchDomain_vpc (1306.48s)
--- PASS: TestAccAWSElasticSearchDomain_vpc_update (3239.89s)
--- PASS: TestAccAWSElasticSearchDomain_withDedicatedMaster (3452.05s)

--- PASS: TestAccAWSElasticSearchDomainPolicy_basic (1600.78s)

--- PASS: TestAccAWSEMRCluster_additionalInfo (509.02s)
--- PASS: TestAccAWSEMRCluster_basic (428.91s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (445.41s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (639.64s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (478.82s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (982.01s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (488.56s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (825.23s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Migration_CoreInstanceType (417.46s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Migration_InstanceGroup (386.07s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (799.01s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (481.47s)
--- PASS: TestAccAWSEMRCluster_disappears (377.84s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (729.59s)
--- PASS: TestAccAWSEMRCluster_instance_group (497.55s)
--- PASS: TestAccAWSEMRCluster_instance_group_EBSVolumeType_st1 (520.38s)
--- PASS: TestAccAWSEMRCluster_instance_group_names (596.00s)
--- PASS: TestAccAWSEMRCluster_instance_group_update (493.37s)
--- PASS: TestAccAWSEMRCluster_keepJob (451.47s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (433.56s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (746.72s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1281.57s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (778.11s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Migration_InstanceGroup (483.64s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Migration_MasterInstanceType (425.17s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (850.44s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (858.22s)
--- PASS: TestAccAWSEMRCluster_s3Logging (508.32s)
--- PASS: TestAccAWSEMRCluster_security_config (576.85s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (586.06s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (395.29s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (855.25s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (454.02s)
--- PASS: TestAccAWSEMRCluster_tags (814.84s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (446.75s)
--- PASS: TestAccAWSEMRCluster_updateAutoScalingPolicy (494.30s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (899.11s)

--- PASS: TestAccAWSEMRInstanceGroup_AutoScalingPolicy (853.38s)
--- PASS: TestAccAWSEMRInstanceGroup_basic (794.28s)
--- PASS: TestAccAWSEMRInstanceGroup_BidPrice (1390.82s)
--- PASS: TestAccAWSEMRInstanceGroup_ConfigurationsJson (842.20s)
--- PASS: TestAccAWSEMRInstanceGroup_EbsConfig_EbsOptimized (1106.71s)
--- PASS: TestAccAWSEMRInstanceGroup_EmrClusterDisappears (679.63s)
--- PASS: TestAccAWSEMRInstanceGroup_InstanceCount (1403.60s)

--- PASS: TestAccAWSEmrSecurityConfiguration_basic (8.76s)

--- PASS: TestAccAWSGlacierVault_basic (8.63s)
--- PASS: TestAccAWSGlacierVault_full (9.14s)
--- PASS: TestAccAWSGlacierVault_RemoveNotifications (14.43s)

--- PASS: TestAccAWSGlacierVaultLock_basic (9.82s)
--- PASS: TestAccAWSGlacierVaultLock_CompleteLock (10.20s)

--- PASS: TestAccAWSGlueCrawler_CatalogTarget (38.61s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget_Multiple (47.35s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (36.80s)
--- PASS: TestAccAWSGlueCrawler_Configuration (37.05s)
--- PASS: TestAccAWSGlueCrawler_Description (37.00s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (30.29s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (38.50s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (38.06s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (46.36s)
--- PASS: TestAccAWSGlueCrawler_recreates (35.97s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (21.88s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (20.64s)
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (28.52s)
--- PASS: TestAccAWSGlueCrawler_S3Target (37.82s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (29.77s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (45.00s)
--- PASS: TestAccAWSGlueCrawler_Schedule (38.24s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (37.62s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (37.94s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (37.14s)
--- PASS: TestAccAWSGlueCrawler_Tags (46.21s)

--- PASS: TestAccAWSIAMRole_badJSON (1.15s)
--- PASS: TestAccAWSIAMRole_basic (10.76s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (23.81s)
--- PASS: TestAccAWSIAMRole_disappears (7.55s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (14.40s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (18.56s)
--- PASS: TestAccAWSIAMRole_namePrefix (10.93s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (36.79s)
--- PASS: TestAccAWSIAMRole_tags (17.40s)
--- PASS: TestAccAWSIAMRole_testNameChange (24.14s)

--- PASS: TestAccAWSIAMRolePolicy_basic (19.89s)
--- PASS: TestAccAWSIAMRolePolicy_disappears (10.60s)
--- PASS: TestAccAWSIAMRolePolicy_generatedName (19.39s)
--- PASS: TestAccAWSIAMRolePolicy_invalidJSON (1.07s)
--- PASS: TestAccAWSIAMRolePolicy_namePrefix (19.99s)
--- PASS: TestAccAWSIAMRolePolicy_Policy_InvalidResource (6.41s)

--- PASS: TestAccAWSKmsExternalKey_basic (26.08s)
--- PASS: TestAccAWSKmsExternalKey_DeletionWindowInDays (31.27s)
--- PASS: TestAccAWSKmsExternalKey_Description (30.91s)
--- PASS: TestAccAWSKmsExternalKey_disappears (24.43s)
--- PASS: TestAccAWSKmsExternalKey_Enabled (155.55s)
--- PASS: TestAccAWSKmsExternalKey_KeyMaterialBase64 (152.20s)
--- PASS: TestAccAWSKmsExternalKey_Tags (36.09s)
--- PASS: TestAccAWSKmsExternalKey_ValidTo (134.44s)

--- PASS: TestAccAWSKmsKey_asymmetricKey (25.37s)
--- PASS: TestAccAWSKmsKey_basic (26.63s)
--- PASS: TestAccAWSKmsKey_disappears (6.53s)
--- PASS: TestAccAWSKmsKey_isEnabled (252.23s)
--- PASS: TestAccAWSKmsKey_policy (31.77s)
--- PASS: TestAccAWSKmsKey_tags (32.26s)

--- PASS: TestAccAWSS3Bucket_acceleration (21.85s)
--- PASS: TestAccAWSS3Bucket_AclToGrant (18.23s)
--- PASS: TestAccAWSS3Bucket_basic (11.21s)
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (11.03s)
--- PASS: TestAccAWSS3Bucket_Cors_Delete (11.79s)
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (13.19s)
--- PASS: TestAccAWSS3Bucket_Cors_Update (19.59s)
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (18.47s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (12.39s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (30.78s)
--- PASS: TestAccAWSS3Bucket_forceDestroy (11.09s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes (9.94s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled (11.26s)
--- PASS: TestAccAWSS3Bucket_generatedName (11.85s)
--- PASS: TestAccAWSS3Bucket_GrantToAcl (18.10s)
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (19.81s)
--- PASS: TestAccAWSS3Bucket_Logging (13.72s)
--- PASS: TestAccAWSS3Bucket_namePrefix (11.57s)
--- PASS: TestAccAWSS3Bucket_objectLock (18.09s)
--- PASS: TestAccAWSS3Bucket_Policy (27.62s)
--- PASS: TestAccAWSS3Bucket_region (11.65s)
--- PASS: TestAccAWSS3Bucket_Replication (129.48s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (87.12s)
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (24.10s)
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (112.93s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (40.15s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (40.30s)
--- PASS: TestAccAWSS3Bucket_RequestPayer (19.03s)
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (7.66s)
--- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (33.35s)
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (79.48s)
--- PASS: TestAccAWSS3Bucket_UpdateAcl (19.13s)
--- PASS: TestAccAWSS3Bucket_UpdateGrant (26.93s)
--- PASS: TestAccAWSS3Bucket_Versioning (26.43s)
--- PASS: TestAccAWSS3Bucket_Website_Simple (25.61s)
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (24.99s)
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (19.05s)
--- PASS: TestAccAWSS3MultiBucket_withTags (13.95s)

--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_basic (11.63s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_removed (16.49s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_updateBasic (25.76s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Empty (1.07s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_MultipleTags (17.35s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Prefix (18.13s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_PrefixAndTags (17.55s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Remove (18.44s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_SingleTag (17.35s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Default (11.24s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Empty (1.00s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Full (11.93s)

--- PASS: TestAccAWSS3BucketInventory_basic (12.77s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSEKMS (29.01s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSES3 (11.71s)

--- PASS: TestAccAWSS3BucketMetric_basic (10.78s)
--- PASS: TestAccAWSS3BucketMetric_WithEmptyFilter (9.68s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterMultipleTags (17.06s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefix (17.44s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags (16.44s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag (16.90s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterSingleTag (17.44s)

--- PASS: TestAccAWSS3BucketNotification_LambdaFunction (33.03s)
--- PASS: TestAccAWSS3BucketNotification_LambdaFunction_LambdaFunctionArn_Alias (32.74s)
--- PASS: TestAccAWSS3BucketNotification_Queue (12.90s)
--- PASS: TestAccAWSS3BucketNotification_Topic (12.99s)
--- PASS: TestAccAWSS3BucketNotification_Topic_Multiple (13.95s)
--- PASS: TestAccAWSS3BucketNotification_update (19.63s)

--- PASS: TestAccAWSS3BucketObject_acl (24.41s)
--- PASS: TestAccAWSS3BucketObject_content (9.92s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (10.27s)
--- PASS: TestAccAWSS3BucketObject_empty (10.26s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (10.84s)
--- PASS: TestAccAWSS3BucketObject_kms (29.19s)
--- PASS: TestAccAWSS3BucketObject_metadata (23.93s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (1.36s)
--- PASS: TestAccAWSS3BucketObject_NonVersioned (10.81s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (24.84s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (17.18s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (25.37s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (30.59s)
--- PASS: TestAccAWSS3BucketObject_source (10.15s)
--- PASS: TestAccAWSS3BucketObject_sse (11.86s)
--- PASS: TestAccAWSS3BucketObject_storageClass (37.17s)
--- PASS: TestAccAWSS3BucketObject_tags (30.42s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (31.04s)
--- PASS: TestAccAWSS3BucketObject_updates (17.59s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (17.71s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (17.64s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (19.48s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (10.76s)

--- PASS: TestAccAWSS3BucketPolicy_basic (12.65s)
--- PASS: TestAccAWSS3BucketPolicy_policyUpdate (19.53s)

--- PASS: TestAccAWSS3BucketPublicAccessBlock_basic (12.28s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_BlockPublicAcls (25.82s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_BlockPublicPolicy (25.48s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_bucketDisappears (8.80s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_disappears (10.79s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_IgnorePublicAcls (25.40s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_RestrictPublicBuckets (25.45s)

--- PASS: TestAccAwsSecretsManagerSecret_Basic (9.27s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (13.90s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (32.67s)
--- PASS: TestAccAwsSecretsManagerSecret_policy (7.35s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (49.94s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (44.62s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (38.99s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (23.26s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (9.10s)

--- PASS: TestAccAwsSecretsManagerSecretVersion_Base64Binary (8.89s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_BasicString (8.47s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_VersionStages (19.44s)

--- PASS: TestAccAWSSESIdentityPolicy_basic (9.48s)
--- PASS: TestAccAWSSESIdentityPolicy_Identity_Email (9.53s)
--- PASS: TestAccAWSSESIdentityPolicy_Policy (15.16s)

--- PASS: TestAccAWSSNSTopic_basic (8.57s)
--- PASS: TestAccAWSSNSTopic_deliveryStatus (23.89s)
--- PASS: TestAccAWSSNSTopic_encryption (14.20s)
--- PASS: TestAccAWSSNSTopic_name (9.16s)
--- PASS: TestAccAWSSNSTopic_namePrefix (8.80s)
--- PASS: TestAccAWSSNSTopic_policy (8.73s)
--- PASS: TestAccAWSSNSTopic_tags (20.13s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (9.00s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (125.13s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (25.72s)

--- PASS: TestAccAWSSNSTopicPolicy_basic (9.30s)

--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (35.16s)
--- PASS: TestAccAWSSNSTopicSubscription_basic (9.19s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (20.42s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (20.10s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (20.85s)

--- PASS: TestAccAWSSQSQueue_basic (20.16s)
--- PASS: TestAccAWSSQSQueue_Encryption (7.99s)
--- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (3.66s)
--- PASS: TestAccAWSSQSQueue_FIFO (8.56s)
--- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (3.85s)
--- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (8.58s)
--- PASS: TestAccAWSSQSQueue_namePrefix (9.20s)
--- PASS: TestAccAWSSQSQueue_namePrefix_fifo (8.69s)
--- PASS: TestAccAWSSQSQueue_policy (9.82s)
--- PASS: TestAccAWSSQSQueue_Policybasic (9.64s)
--- PASS: TestAccAWSSQSQueue_queueDeletedRecently (79.37s)
--- PASS: TestAccAWSSQSQueue_redrivePolicy (9.59s)
--- PASS: TestAccAWSSQSQueue_tags (19.91s)

--- PASS: TestAccAWSSQSQueuePolicy_basic (8.76s)

--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (21.12s)
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (34.24s)
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicyAndTags (39.01s)
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (101.25s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSService (270.04s)
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (344.60s)
--- PASS: TestAccAWSVpcEndpoint_removed (15.31s)

--- PASS: TestAccAWSVpcEndpointConnectionNotification_basic (250.06s)

--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (22.18s)

--- PASS: TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags (248.90s)
--- PASS: TestAccAWSVpcEndpointService_basic (245.68s)
--- PASS: TestAccAWSVpcEndpointService_removed (249.43s)
--- PASS: TestAccAWSVpcEndpointServiceAllowedPrincipal_basic (217.69s)

--- PASS: TestAccAWSVpcEndpointSubnetAssociation_basic (254.18s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_multiple (587.43s)

--- PASS: TestAccDataSourceAwsLambdaInvocation_basic (37.09s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_complex (37.57s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_qualifier (36.15s)
```

* resource/aws_apigatewayv2_model: Replace deprecated validation.ValidateJsonString with validation.StringIsJSON

Reference: #11844
Reference: #12087

Output from acceptance testing:

```
--- PASS: TestAccAWSAPIGatewayV2Model_disappears (18.58s)
--- PASS: TestAccAWSAPIGatewayV2Model_basic (20.32s)
--- PASS: TestAccAWSAPIGatewayV2Model_AllAttributes (46.23s)
```
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
2 participants