Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: add support for schedule and OutPutLocation to aws_ssm_association #1246

Closed
sfrode opened this issue Jul 26, 2017 · 2 comments · Fixed by #1253
Closed

FR: add support for schedule and OutPutLocation to aws_ssm_association #1246

sfrode opened this issue Jul 26, 2017 · 2 comments · Fixed by #1253
Labels
enhancement Requests to existing resources that expand the functionality or scope.

Comments

@sfrode
Copy link

sfrode commented Jul 26, 2017

Hi!

EC2 SSM has received a number of new features lately, including support for writing data to S3 buckets that can be used to get control over software inventories, etc as described in the AWS blog.

It would be great if rthe resource aws_ssm_association could be updated to support all the options that the AWS SSM API "CreateAssociationInput" supports. As far as I can tell, support for the following is missing:

ScheduledExpression
OutputLocation

Here is the AWS Cloudformation description of the same.

Thank you - and keep up the good work!
@Ninir Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 26, 2017
@sfrode
Copy link
Author

sfrode commented Jul 27, 2017

Come to think of it, it would be great if aws_ssm_association could get support for calling UpdateAssociation rather than enforcing ForceNew on every single modification as well. This would be beneficial where one are changing tags, schedules, etc.

stack72 added a commit to stack72/terraform-provider-aws that referenced this issue Jul 27, 2017
@stack72
resource/aws_ssm_association: Add support for OutputLocation and Sche…
7d79ebc 
…dule Expression

Fixes: hashicorp#1246

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMAssociation_ -timeout 120m
=== RUN   TestAccAWSSSMAssociation_basic
--- PASS: TestAccAWSSSMAssociation_basic (135.40s)
=== RUN   TestAccAWSSSMAssociation_withTargets
--- PASS: TestAccAWSSSMAssociation_withTargets (32.06s)
=== RUN   TestAccAWSSSMAssociation_withOutputLocation
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (58.07s)
=== RUN   TestAccAWSSSMAssociation_withScheduleExpression
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (31.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	256.727s
```
@stack72 stack72 mentioned this issue Jul 27, 2017
Merged
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
No milestone
2 participants
@Ninir @sfrode