[PLACEHOLDER] Internalize or Migrate Import of github.com/hashicorp/terraform-plugin-sdk/helper/hashcode from Deprecation

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The functionality provided by github.com/hashicorp/terraform-plugin-sdk/helper/hashcode is deprecated in v1 without replacement as of Terraform Plugin SDK version 1.13.0. We currently have 126 uses of hashcode.String(), a simple function to convert a string into an absolute value hash acceptable for TypeSet attribute Set functions.

While it is not a major issue to keep the old v1 dependency around, it would likely be less confusing longer term to internalize it, especially since it is tiny and may no longer apply to the Terraform Plugin SDK schema handling when cty types are the norm in the future.

Definition of Done

• Potentially: Code internalized in new aws/internal/hashcode package
• Potentially: Update existing github.com/hashicorp/terraform-plugin-sdk/helper/hashcode imports to github.com/terraform-providers/terraform-provider-aws/aws/internal/hashcode
• Add .hashibot.hcl configuration with new deprecated_import_commenter behavior
• Ensure go mod tidy and go mod vendor no longer report the dependency and removes the code from the vendor/github.com/hashicorp/terraform-plugin-sdk/helper/hashcode directory

[ghost]

This has been released in version 3.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!