Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TF SDKv1 #14593

Merged
merged 6 commits into from
Aug 12, 2020
Merged

Remove TF SDKv1 #14593

merged 6 commits into from
Aug 12, 2020

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Aug 11, 2020 •
edited
Loading

Follow up to #14432 this removes the reliance on deprecated helper packages and internalizes them. I pruned what I could. The internalized vault packages were originally lifted and shifted to the SDK when it became its own repo, that's why it had to be copied over here.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13445
Closes #13446
Closes #13447

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@appilon appilon requested a review from a team August 11, 2020 23:37
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/acm Issues and PRs that pertain to the acm service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appmesh Issues and PRs that pertain to the appmesh service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/iam Issues and PRs that pertain to the iam service. service/opsworks Issues and PRs that pertain to the opsworks service. service/pricing Issues and PRs that pertain to the pricing service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 11, 2020
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by Renovate Bot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod, go.sum, and vendor/ files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via Renovate Bot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via Renovate Bot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@appilon appilon changed the title Remove SDKv1 Remove TF SDKv1 Aug 11, 2020
@appilon appilon force-pushed the td-internalize-v1-imports branch from 218bec1 to bd6bedb Compare August 12, 2020 01:48
@appilon appilon mentioned this pull request Aug 12, 2020
Closed
@bflad bflad added this to the v3.2.0 milestone Aug 12, 2020
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. dependencies Used to indicate dependency changes. labels Aug 12, 2020
bflad
bflad approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

@bflad
Copy link
Contributor

bflad commented Aug 12, 2020

Oh! Actually the issues to mention adding hashibot configuration as well, which would be good here to direct contributors to the new locations.

Add .hashibot.hcl configuration with new deprecated_import_commenter behavior

@appilon
Copy link
Contributor Author

appilon commented Aug 12, 2020

I will cherry pick the other PR and get that in.

@appilon appilon merged commit 752b0b6 into master Aug 12, 2020
@appilon appilon deleted the td-internalize-v1-imports branch August 12, 2020 19:14
@bflad bflad mentioned this pull request Aug 13, 2020
Merged
@ghost
Copy link

ghost commented Aug 14, 2020

This has been released in version 3.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. service/acm Issues and PRs that pertain to the acm service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appmesh Issues and PRs that pertain to the appmesh service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/iam Issues and PRs that pertain to the iam service. service/opsworks Issues and PRs that pertain to the opsworks service. service/pricing Issues and PRs that pertain to the pricing service. size/XXL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.2.0
3 participants
@appilon @bflad @j1king