Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Wavelength support #14518

Closed
7 tasks done
ewbankkit opened this issue Aug 7, 2020 · 14 comments · Fixed by #16963
Closed
7 tasks done

AWS Wavelength support #14518

ewbankkit opened this issue Aug 7, 2020 · 14 comments · Fixed by #16963
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Aug 7, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS Wavelength is now available in us-east-1 and us-west-2.

New or Affected Resource(s)

New
  • aws_ec2_carrier_gateway (version 3.21.0)
Updated

aws_default_route_table

Error: error creating route: RouteNotSupported: Routes that target carrier gateways are not supported in main route table.

Potential Terraform Configuration

resource "aws_ec2_carrier_gateway" "example" {
  vpc_id = aws_vpc.example.id

  tags = {
    Name = "Example"
  }
}

References

Announcement.
Blog post.

Requires AWS SDK v1.33.21:

Related:

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 7, 2020
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Aug 7, 2020
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Aug 7, 2020
@jukie
Copy link
Contributor

jukie commented Aug 9, 2020

I can work on this if you haven't already started @ewbankkit

@ewbankkit
Copy link
Contributor Author

@jukie If you have bandwidth, a PR for the the aws_ec2_carrier_gateway resource (and then one for the corresponding data source) would be great.
I'm not sure if you need to have an account with Wavelength enabled to actually create a Carrier Gateway.
I will tackle the routing enhancements as part of another set of PRs I am working on.
Thanks.

@FireballDWF
Copy link

@ewbankkit If you have made any progress and would like someone to help test or troubleshoot, I'm willing. I'm AWS ProServe and willing to help push things within AWS if you need any support.

@ewbankkit
Copy link
Contributor Author

@FireballDWF Thanks for the offer.
Would you be able to suggest a priority order for the changes?

@FireballDWF
Copy link

FireballDWF commented Nov 17, 2020 via email

@FireballDWF
Copy link

FireballDWF commented Nov 20, 2020

Proposed priority

  1. aws_route
  2. aws_route_table
  3. aws_eip
  4. aws_launch_template
  5. aws_network_interface
  6. aws_default_route_table

@FireballDWF
Copy link

I received access an hour ago to a wavelength account. I can attempt to build on Saturday morning. If you can include the aws_route resource change, that is sufficient for a minimal practical test.

@ewbankkit
Copy link
Contributor Author

@FireballDWF I have added (hopefully) sufficient support to aws_route in #16252.
Please add any results to that PR.
Thanks.

@bflad
Copy link
Contributor

bflad commented Dec 9, 2020

Support for the new aws_ec2_carrier_gateway resource has been merged and will release with version 3.21.0 of the Terraform AWS Provider, likely tomorrow. Thanks to @ewbankkit for the implementation.

@ewbankkit
Copy link
Contributor Author

The aws_eip resource changes for Wavelength (adding network_border_group attribute) was implemented via #14028, released in version 3.14.0 of the Terraform AWS Provider.

@FireballDWF
Copy link

@FireballDWF I have added (hopefully) sufficient support to aws_route in #16252.
Please add any results to that PR.
Thanks.

I did not see any changes to aws_route in that PR, and don't see the changes for aws_route anywhere else in the latest release. However I successfully tested aws_ec2_carrier_gateway in the latest release.

@ewbankkit
Copy link
Contributor Author

ewbankkit commented Dec 14, 2020

@FireballDWF I pulled out the commit that updated aws_route before #16252 was merged so as reduce the scope to one resource per PR.
I have a couple of precursor PRs (#14014 and then #16930) that could be merged first for aws_route or we could add the (relatively minor) change to add a carrier_gateway_id attribute on top of the current code - Brian can make that call.

@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 26, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants