Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_availability_zone: Additional attributes for Local and Wavelength Zones #16770

Merged
merged 5 commits into from
Dec 15, 2020
Merged

d/aws_availability_zone: Additional attributes for Local and Wavelength Zones #16770

merged 5 commits into from
Dec 15, 2020

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14518.

Release note for CHANGELOG:

data-source/aws_availability_zone: Add `parent_zone_id`, `parent_zone_name` and `zone_type` attributes for better Local and Wavelength Zone support.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsAvailabilityZone_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsAvailabilityZone_ -timeout 120m
=== RUN   TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== PAUSE TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== RUN   TestAccDataSourceAwsAvailabilityZone_Filter
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Filter
=== RUN   TestAccDataSourceAwsAvailabilityZone_LocalZone
=== PAUSE TestAccDataSourceAwsAvailabilityZone_LocalZone
=== RUN   TestAccDataSourceAwsAvailabilityZone_Name
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Name
=== RUN   TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== PAUSE TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== RUN   TestAccDataSourceAwsAvailabilityZone_ZoneId
=== PAUSE TestAccDataSourceAwsAvailabilityZone_ZoneId
=== CONT  TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== CONT  TestAccDataSourceAwsAvailabilityZone_ZoneId
=== CONT  TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== CONT  TestAccDataSourceAwsAvailabilityZone_Name
=== CONT  TestAccDataSourceAwsAvailabilityZone_LocalZone
=== CONT  TestAccDataSourceAwsAvailabilityZone_Filter
--- PASS: TestAccDataSourceAwsAvailabilityZone_Name (17.92s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (19.40s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_WavelengthZone (20.22s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_LocalZone (20.37s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (20.69s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Filter (20.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	20.770s

@ewbankkit
d/aws_availability_zone: Add 'zone_type' attribute.
c41bd7e 
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsAvailabilityZone_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsAvailabilityZone_ -timeout 120m
=== RUN   TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== PAUSE TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== RUN   TestAccDataSourceAwsAvailabilityZone_Filter
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Filter
=== RUN   TestAccDataSourceAwsAvailabilityZone_Name
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Name
=== RUN   TestAccDataSourceAwsAvailabilityZone_ZoneId
=== PAUSE TestAccDataSourceAwsAvailabilityZone_ZoneId
=== CONT  TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== CONT  TestAccDataSourceAwsAvailabilityZone_Filter
=== CONT  TestAccDataSourceAwsAvailabilityZone_ZoneId
=== CONT  TestAccDataSourceAwsAvailabilityZone_Name
--- PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (14.09s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Filter (15.90s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (16.10s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Name (16.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.194s
@ewbankkit
d/aws_availability_zone: Add Local Zone test.
4d33eab 
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsAvailabilityZone_LocalZone'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsAvailabilityZone_LocalZone -timeout 120m
=== RUN   TestAccDataSourceAwsAvailabilityZone_LocalZone
=== PAUSE TestAccDataSourceAwsAvailabilityZone_LocalZone
=== CONT  TestAccDataSourceAwsAvailabilityZone_LocalZone
--- PASS: TestAccDataSourceAwsAvailabilityZone_LocalZone (10.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	10.625s
@ewbankkit
d/aws_availability_zone: Add Wavelength Zone test.
03b46fd 
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsAvailabilityZone_WavelengthZone'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsAvailabilityZone_WavelengthZone -timeout 120m
=== RUN   TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== PAUSE TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== CONT  TestAccDataSourceAwsAvailabilityZone_WavelengthZone
--- PASS: TestAccDataSourceAwsAvailabilityZone_WavelengthZone (10.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	10.711s
@ewbankkit
d/aws_availability_zone: Add 'parent_zone_id' and 'parent_zone_name' …
2515701 
…attributes.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsAvailabilityZone_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsAvailabilityZone_ -timeout 120m
=== RUN   TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== PAUSE TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== RUN   TestAccDataSourceAwsAvailabilityZone_Filter
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Filter
=== RUN   TestAccDataSourceAwsAvailabilityZone_LocalZone
=== PAUSE TestAccDataSourceAwsAvailabilityZone_LocalZone
=== RUN   TestAccDataSourceAwsAvailabilityZone_Name
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Name
=== RUN   TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== PAUSE TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== RUN   TestAccDataSourceAwsAvailabilityZone_ZoneId
=== PAUSE TestAccDataSourceAwsAvailabilityZone_ZoneId
=== CONT  TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== CONT  TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== CONT  TestAccDataSourceAwsAvailabilityZone_ZoneId
=== CONT  TestAccDataSourceAwsAvailabilityZone_LocalZone
=== CONT  TestAccDataSourceAwsAvailabilityZone_Name
=== CONT  TestAccDataSourceAwsAvailabilityZone_Filter
--- PASS: TestAccDataSourceAwsAvailabilityZone_Filter (19.67s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (21.28s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_WavelengthZone (21.55s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Name (21.65s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (21.69s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_LocalZone (21.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.778s
@ewbankkit
d/aws_availability_zone: Remove leading '-' from 'name_suffix' for Lo…
7b5dbae 
…cal and Wavelength Zones.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsAvailabilityZone_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsAvailabilityZone_ -timeout 120m
=== RUN   TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== PAUSE TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== RUN   TestAccDataSourceAwsAvailabilityZone_Filter
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Filter
=== RUN   TestAccDataSourceAwsAvailabilityZone_LocalZone
=== PAUSE TestAccDataSourceAwsAvailabilityZone_LocalZone
=== RUN   TestAccDataSourceAwsAvailabilityZone_Name
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Name
=== RUN   TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== PAUSE TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== RUN   TestAccDataSourceAwsAvailabilityZone_ZoneId
=== PAUSE TestAccDataSourceAwsAvailabilityZone_ZoneId
=== CONT  TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== CONT  TestAccDataSourceAwsAvailabilityZone_ZoneId
=== CONT  TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== CONT  TestAccDataSourceAwsAvailabilityZone_Name
=== CONT  TestAccDataSourceAwsAvailabilityZone_LocalZone
=== CONT  TestAccDataSourceAwsAvailabilityZone_Filter
--- PASS: TestAccDataSourceAwsAvailabilityZone_Name (17.92s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (19.40s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_WavelengthZone (20.22s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_LocalZone (20.37s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (20.69s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Filter (20.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	20.770s
@ewbankkit ewbankkit requested a review from a team as a code owner December 15, 2020 15:28
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 15, 2020
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 15, 2020
@bflad bflad self-assigned this Dec 15, 2020
@bflad bflad added this to the v3.22.0 milestone Dec 15, 2020
bflad
bflad approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you, @ewbankkit 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (19.39s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_WavelengthZone (19.71s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Filter (19.91s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Name (19.97s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_LocalZone (19.98s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (19.98s)

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccDataSourceAwsAvailabilityZone_LocalZone (3.70s)
--- SKIP: TestAccDataSourceAwsAvailabilityZone_WavelengthZone (3.73s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (21.76s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (22.26s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Filter (22.26s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Name (22.66s)

@bflad bflad merged commit 896c7d3 into hashicorp:master Dec 15, 2020
bflad added a commit that referenced this pull request Dec 15, 2020
@bflad
Update CHANGELOG for #16770
e7bf763
@ewbankkit ewbankkit deleted the f-aws_availability_zone-zone_type branch December 15, 2020 16:03
@ghost
Copy link

ghost commented Dec 18, 2020

This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @bflad