Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/storagegateway_gateway - smb file share visibility #18076

Merged
merged 4 commits into from
Mar 17, 2021
Merged

r/storagegateway_gateway - smb file share visibility #18076

merged 4 commits into from
Mar 17, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18058

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSStorageGatewayGateway_SMBVisibility (432.84s)
--- PASS: TestAccAWSStorageGatewayGateway_SMBSecurityStrategy (380.31s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner March 12, 2021 21:14
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 12, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 12, 2021
@DrFaust92 @ewbankkit
Apply suggestions from code review
23da6fc 
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
ewbankkit
ewbankkit approved these changes Mar 14, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSStorageGatewayGateway_' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSStorageGatewayGateway_ -timeout 180m
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Stored
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Stored
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Vtl
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Vtl
=== RUN   TestAccAWSStorageGatewayGateway_tags
=== PAUSE TestAccAWSStorageGatewayGateway_tags
=== RUN   TestAccAWSStorageGatewayGateway_GatewayName
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayName
=== RUN   TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== PAUSE TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== RUN   TestAccAWSStorageGatewayGateway_GatewayTimezone
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayTimezone
=== RUN   TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
=== RUN   TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
=== PAUSE TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
=== RUN   TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== PAUSE TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== RUN   TestAccAWSStorageGatewayGateway_SmbGuestPassword
=== PAUSE TestAccAWSStorageGatewayGateway_SmbGuestPassword
=== RUN   TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
=== PAUSE TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
=== RUN   TestAccAWSStorageGatewayGateway_SMBVisibility
=== PAUSE TestAccAWSStorageGatewayGateway_SMBVisibility
=== RUN   TestAccAWSStorageGatewayGateway_disappears
=== PAUSE TestAccAWSStorageGatewayGateway_disappears
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthUpload
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthUpload
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthDownload
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthDownload
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthAll
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthAll
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== CONT  TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthAll
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (226.22s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthDownload
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthAll (288.17s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthUpload
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthDownload (304.79s)
=== CONT  TestAccAWSStorageGatewayGateway_disappears
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthUpload (289.52s)
=== CONT  TestAccAWSStorageGatewayGateway_SMBVisibility
--- PASS: TestAccAWSStorageGatewayGateway_disappears (182.13s)
=== CONT  TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout (812.62s)
=== CONT  TestAccAWSStorageGatewayGateway_SmbGuestPassword
--- PASS: TestAccAWSStorageGatewayGateway_SMBVisibility (276.48s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayName
--- PASS: TestAccAWSStorageGatewayGateway_SMBSecurityStrategy (213.26s)
=== CONT  TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (219.42s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (263.33s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayTimezone
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (222.12s)
=== CONT  TestAccAWSStorageGatewayGateway_CloudWatchLogs
--- PASS: TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint (381.85s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Vtl
--- PASS: TestAccAWSStorageGatewayGateway_CloudWatchLogs (219.95s)
=== CONT  TestAccAWSStorageGatewayGateway_tags
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (250.34s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Stored
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (785.05s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_tags (269.16s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (198.44s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (209.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1920.922s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSStorageGatewayGateway_' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSStorageGatewayGateway_ -timeout 180m
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Stored
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Stored
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Vtl
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Vtl
=== RUN   TestAccAWSStorageGatewayGateway_tags
=== PAUSE TestAccAWSStorageGatewayGateway_tags
=== RUN   TestAccAWSStorageGatewayGateway_GatewayName
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayName
=== RUN   TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== PAUSE TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== RUN   TestAccAWSStorageGatewayGateway_GatewayTimezone
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayTimezone
=== RUN   TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
=== RUN   TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
=== PAUSE TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
=== RUN   TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== PAUSE TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== RUN   TestAccAWSStorageGatewayGateway_SmbGuestPassword
=== PAUSE TestAccAWSStorageGatewayGateway_SmbGuestPassword
=== RUN   TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
=== PAUSE TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
=== RUN   TestAccAWSStorageGatewayGateway_SMBVisibility
=== PAUSE TestAccAWSStorageGatewayGateway_SMBVisibility
=== RUN   TestAccAWSStorageGatewayGateway_disappears
=== PAUSE TestAccAWSStorageGatewayGateway_disappears
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthUpload
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthUpload
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthDownload
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthDownload
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthAll
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthAll
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== CONT  TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthAll
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (227.51s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthDownload
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthAll (251.66s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthUpload
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthDownload (246.93s)
=== CONT  TestAccAWSStorageGatewayGateway_disappears
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthUpload (233.37s)
=== CONT  TestAccAWSStorageGatewayGateway_SMBVisibility
--- PASS: TestAccAWSStorageGatewayGateway_disappears (216.29s)
=== CONT  TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
--- PASS: TestAccAWSStorageGatewayGateway_SMBVisibility (271.14s)
=== CONT  TestAccAWSStorageGatewayGateway_SmbGuestPassword
--- PASS: TestAccAWSStorageGatewayGateway_SMBSecurityStrategy (200.92s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayName
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout (922.97s)
=== CONT  TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (210.40s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (232.71s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayTimezone
--- PASS: TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint (364.29s)
=== CONT  TestAccAWSStorageGatewayGateway_CloudWatchLogs
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (213.67s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Vtl
--- PASS: TestAccAWSStorageGatewayGateway_CloudWatchLogs (186.16s)
=== CONT  TestAccAWSStorageGatewayGateway_tags
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (199.92s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Stored
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (803.78s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (192.54s)
--- PASS: TestAccAWSStorageGatewayGateway_tags (237.75s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (229.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1959.315s

Verified Acceptance Tests in GovCloud (us-gov-west-1). Note that Simple AD test failures are a known issue and are covered here: #16172

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSStorageGatewayGateway_' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSStorageGatewayGateway_ -timeout 180m
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Stored
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Stored
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Vtl
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Vtl
=== RUN   TestAccAWSStorageGatewayGateway_tags
=== PAUSE TestAccAWSStorageGatewayGateway_tags
=== RUN   TestAccAWSStorageGatewayGateway_GatewayName
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayName
=== RUN   TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== PAUSE TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== RUN   TestAccAWSStorageGatewayGateway_GatewayTimezone
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayTimezone
=== RUN   TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
=== RUN   TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
=== PAUSE TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
=== RUN   TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== PAUSE TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== RUN   TestAccAWSStorageGatewayGateway_SmbGuestPassword
=== PAUSE TestAccAWSStorageGatewayGateway_SmbGuestPassword
=== RUN   TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
=== PAUSE TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
=== RUN   TestAccAWSStorageGatewayGateway_SMBVisibility
=== PAUSE TestAccAWSStorageGatewayGateway_SMBVisibility
=== RUN   TestAccAWSStorageGatewayGateway_disappears
=== PAUSE TestAccAWSStorageGatewayGateway_disappears
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthUpload
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthUpload
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthDownload
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthDownload
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthAll
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthAll
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== CONT  TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
=== CONT  TestAccAWSStorageGatewayGateway_GatewayName
=== CONT  TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
    resource_aws_storagegateway_gateway_test.go:400: Step 1/2 error: Error running apply: exit status 1
        2021/03/17 11:05:16 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.13.0

        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: a7dcb8ae-b4b2-4c01-9f0e-d1cede25e138 : RequestId: a7dcb8ae-b4b2-4c01-9f0e-d1cede25e138
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "a7dcb8ae-b4b2-4c01-9f0e-d1cede25e138"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: a7dcb8ae-b4b2-4c01-9f0e-d1cede25e138 : RequestId: a7dcb8ae-b4b2-4c01-9f0e-d1cede25e138",
          RequestId: "a7dcb8ae-b4b2-4c01-9f0e-d1cede25e138"
        }

          on terraform_plugin_test.tf line 83, in resource "aws_directory_service_directory" "test":
          83: resource "aws_directory_service_directory" "test" {


--- FAIL: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (21.19s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (198.37s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayTimezone
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (227.81s)
=== CONT  TestAccAWSStorageGatewayGateway_CloudWatchLogs
--- PASS: TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint (260.54s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Vtl
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (202.36s)
=== CONT  TestAccAWSStorageGatewayGateway_tags
--- PASS: TestAccAWSStorageGatewayGateway_CloudWatchLogs (192.47s)
=== CONT  TestAccAWSStorageGatewayGateway_disappears
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (167.69s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthAll
--- PASS: TestAccAWSStorageGatewayGateway_disappears (169.39s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthDownload
--- PASS: TestAccAWSStorageGatewayGateway_tags (207.69s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthUpload
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthAll (247.40s)
=== CONT  TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthDownload (220.61s)
=== CONT  TestAccAWSStorageGatewayGateway_SMBVisibility
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthUpload (207.73s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Stored
--- PASS: TestAccAWSStorageGatewayGateway_SMBSecurityStrategy (215.97s)
=== CONT  TestAccAWSStorageGatewayGateway_SmbGuestPassword
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (180.40s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_SMBVisibility (229.70s)
=== CONT  TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
    resource_aws_storagegateway_gateway_test.go:430: Step 1/2 error: Error running apply: exit status 1
        2021/03/17 11:22:34 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.13.0

        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 6ec6c8d6-1945-409a-8f28-7ba1ecf44ffa : RequestId: 6ec6c8d6-1945-409a-8f28-7ba1ecf44ffa
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "6ec6c8d6-1945-409a-8f28-7ba1ecf44ffa"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 6ec6c8d6-1945-409a-8f28-7ba1ecf44ffa : RequestId: 6ec6c8d6-1945-409a-8f28-7ba1ecf44ffa",
          RequestId: "6ec6c8d6-1945-409a-8f28-7ba1ecf44ffa"
        }

          on terraform_plugin_test.tf line 83, in resource "aws_directory_service_directory" "test":
          83: resource "aws_directory_service_directory" "test" {


--- FAIL: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout (18.97s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (234.61s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (179.87s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	1179.367s
FAIL
make: *** [testacc] Error 1

@breathingdust breathingdust merged commit 867b138 into hashicorp:main Mar 17, 2021
@DrFaust92 DrFaust92 mentioned this pull request Mar 17, 2021
Closed
@dthvt dthvt mentioned this pull request Mar 25, 2021
Closed
@DrFaust92 DrFaust92 deleted the r/storagegateway_smb_visible branch April 15, 2021 10:34
@ghost
Copy link

ghost commented Apr 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_storagegateway_gateway - Share Visibility Toggle does not appear to be available.
3 participants
@DrFaust92 @breathingdust @ewbankkit