f/resource_aws_mq_broker: Adds validation to broker_name and security_groups arguments in resource_aws_mq_broker

[kubawi]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17966

It's my first contribution to terraform-provider-aws. I tried my best to follow the contribution guides, but please let me know if I missed something. As far as the code change goes, I followed the patterns I could notice in the codebase, but any feedback is welcome.

Output from acceptance testing:

➜ make testacc TESTARGS='-run=TestValidateMQBrokerName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestValidateMQBrokerName -timeout 180m
=== RUN   TestValidateMQBrokerName
--- PASS: TestValidateMQBrokerName (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1.551s

[github-actions]

Welcome @kubawi 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[gdavison]

Thanks for the PR, @kubawi, it looks great! I have one comment about the regex used for validation. It would also be good to update the documentation to reflect the new validation.

You can make the suggested changes, or I can make them and merge your contribution.

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[gdavison]

Thanks for the PR, @kubawi, and apologies for the delay

Looks good! 🚀

Acceptance test results

--- PASS: TestValidateBrokerName (0.00s)
--- PASS: TestBrokerPasswordValidation (0.00s)
--- PASS: TestDiffUsers (0.00s)
--- PASS: TestAccMQBroker_RabbitMQ_logs (712.66s)
--- PASS: TestAccMQBroker_RabbitMQ_validationAuditLog (776.08s)
--- PASS: TestAccMQBroker_throughputOptimized (868.59s)
--- PASS: TestAccMQBroker_RabbitMQ_basic (938.51s)
--- PASS: TestAccMQBroker_ldap (1049.03s)
--- PASS: TestAccMQBroker_RabbitMQ_cluster (1053.95s)
--- PASS: TestAccMQBroker_EncryptionOptions_awsOwnedKeyEnabled (1060.23s)
--- PASS: TestAccMQBrokerDataSource_basic (1095.74s)
--- PASS: TestAccMQBroker_basic (1100.66s)
--- PASS: TestAccMQBroker_Update_tags (1100.68s)
--- PASS: TestAccMQBroker_EncryptionOptions_awsOwnedKeyDisabled (1113.39s)
--- PASS: TestAccMQBroker_EncryptionOptions_kmsKeyID (1120.97s)
--- PASS: TestAccMQBroker_disappears (1139.20s)
--- PASS: TestAccMQBroker_Update_securityGroup (1331.22s)
--- PASS: TestAccMQBroker_Update_engineVersion (1348.04s)
--- PASS: TestAccMQBroker_Update_users (1483.20s)
--- PASS: TestAccMQBroker_Update_hostInstanceType (1695.80s)
--- PASS: TestAccMQBroker_AllFields_defaultVPC (1768.20s)
--- PASS: TestAccMQBroker_AllFields_customVPC (1814.28s)

[github-actions]

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.