f/resource_aws_mq_broker: Adds validation to broker_name and security_groups arguments in resource_aws_mq_broker

.changelog/18088.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_mq_broker: Add validation to broker_name and security_groups arguments
+```

internal/service/mq/broker.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"log"
 	"reflect"
+	"regexp"
 	"strconv"
 	"strings"
 
@@ -58,9 +59,10 @@ func ResourceBroker() *schema.Resource {
 				Default:  false,
 			},
 			"broker_name": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: ValidateBrokerName,
 			},
 			"configuration": {
 				Type:     schema.TypeList,
@@ -264,6 +266,7 @@ func ResourceBroker() *schema.Resource {
 				Type:     schema.TypeSet,
 				Elem:     &schema.Schema{Type: schema.TypeString},
 				Optional: true,
+				MaxItems: 5,
 			},
 			"storage_type": {
 				Type:         schema.TypeString,
@@ -1093,3 +1096,8 @@ func expandMQLDAPServerMetadata(tfList []interface{}) *mq.LdapServerMetadataInpu
 
 	return apiObject
 }
+
+var ValidateBrokerName = validation.All(
+	validation.StringLenBetween(1, 50),
+	validation.StringMatch(regexp.MustCompile(`^[0-9A-Za-z_-]+$`), ""),
+)

internal/service/mq/broker_test.go

@@ -18,6 +18,37 @@ import (
 	tfmq "github.com/hashicorp/terraform-provider-aws/internal/service/mq"
 )
 
+func TestValidateBrokerName(t *testing.T) {
+	validNames := []string{
+		"ValidName",
+		"V_-dN01e",
+		"0",
+		"-",
+		"_",
+		strings.Repeat("x", 50),
+	}
+	for _, v := range validNames {
+		_, errors := tfmq.ValidateBrokerName(v, "name")
+		if len(errors) != 0 {
+			t.Fatalf("%q should be a valid broker name: %q", v, errors)
+		}
+	}
+
+	invalidNames := []string{
+		"Inval:d.~Name",
+		"Invalid Name",
+		"*",
+		"",
+		strings.Repeat("x", 51),
+	}
+	for _, v := range invalidNames {
+		_, errors := tfmq.ValidateBrokerName(v, "name")
+		if len(errors) == 0 {
+			t.Fatalf("%q should be an invalid broker name", v)
+		}
+	}
+}
+
 func TestBrokerPasswordValidation(t *testing.T) {
 	cases := []struct {
 		Value    string