resource/aws_sns_topic_subscription: Handle read-after-create eventual consistency, enforce lowercase protocol argument validation #18475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l consistency, enforce lowercase protocol argument validation Reference: #10225 Reference: #11737 Reference: #12692 Reference: #16695 Reference: #16796 The `protocol` validation update is to catch where the API accepts uppercase values such as `HTTPS`, but prevents proper handling when the API canonicalizes it to lowercase. The API documentation and existing Terraform documentation solely use lowercase. Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (95.60s) --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (137.43s) --- PASS: TestAccAWSSNSTopicSubscription_basic (66.20s) --- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (69.55s) --- PASS: TestAccAWSSNSTopicSubscription_disappears (74.02s) --- PASS: TestAccAWSSNSTopicSubscription_disappears_topic (75.13s) --- PASS: TestAccAWSSNSTopicSubscription_email (16.78s) --- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (71.62s) --- PASS: TestAccAWSSNSTopicSubscription_firehose (140.29s) --- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (69.77s) --- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (64.88s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSSNSTopicSubscription_basic (70.13s) --- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (106.45s) --- PASS: TestAccAWSSNSTopicSubscription_disappears (82.09s) --- PASS: TestAccAWSSNSTopicSubscription_disappears_topic (68.14s) --- PASS: TestAccAWSSNSTopicSubscription_email (20.04s) --- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (106.32s) --- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (95.36s) --- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (110.75s) --- SKIP: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (1.41s) --- SKIP: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (1.41s) --- SKIP: TestAccAWSSNSTopicSubscription_firehose (53.36s) ```
ghost
added
size/S
YakDriver
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Looks great! 🎉
Acceptance tests in commercial (us-west-2):
--- PASS: TestAccAWSSNSTopicSubscription_email (17.13s)
--- PASS: TestAccAWSSNSTopicSubscription_basic (65.46s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (67.27s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (67.62s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (67.71s)
--- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (71.02s)
--- PASS: TestAccAWSSNSTopicSubscription_disappears (72.42s)
--- PASS: TestAccAWSSNSTopicSubscription_disappears_topic (74.22s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (90.38s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (124.65s)
--- PASS: TestAccAWSSNSTopicSubscription_firehose (129.62s)
Acceptance tests in GovCloud:
--- SKIP: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (1.23s)
--- SKIP: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (1.24s)
--- PASS: TestAccAWSSNSTopicSubscription_email (20.31s)
--- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (58.91s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (64.65s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (65.24s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (65.29s)
--- PASS: TestAccAWSSNSTopicSubscription_disappears_topic (68.05s)
--- SKIP: TestAccAWSSNSTopicSubscription_firehose (69.61s)
--- PASS: TestAccAWSSNSTopicSubscription_basic (70.51s)
--- PASS: TestAccAWSSNSTopicSubscription_disappears (76.44s)
|
This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #10225
Closes #11737
Closes #12692
Closes #16695
Reference: #16796
The
protocolvalidation update is to catch where the API accepts uppercase values such asHTTPS, but prevents proper handling when the API canonicalizes it to lowercase. The API documentation and existing Terraform documentation solely use lowercase.Output from acceptance testing in AWS Commercial:
Output from acceptance testing in AWS GovCloud (US):