Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_budgets_budget: time_period_start to be optional instead of required #19803

Closed
farhanangullia opened this issue Jun 15, 2021 · 2 comments · Fixed by #9092
Closed

aws_budgets_budget: time_period_start to be optional instead of required #19803

farhanangullia opened this issue Jun 15, 2021 · 2 comments · Fixed by #9092
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/budgets Issues and PRs that pertain to the budgets service.
Milestone
v3.52.0

Comments

@farhanangullia
Copy link
Contributor

farhanangullia commented Jun 15, 2021 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Will be useful to have the time_period_start argument as optional. If you don't specify a start date, the upstream API will default it to the start of your chosen time period (DAILY, MONTHLY, QUARTERLY, or ANNUALLY) from time_unit.

New or Affected Resource(s)

  • aws_budgets_budget

References
@farhanangullia farhanangullia added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 15, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/budgets Issues and PRs that pertain to the budgets service. labels Jun 15, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 15, 2021
@ewbankkit ewbankkit mentioned this issue Jul 26, 2021
Merged
ewbankkit added a commit that referenced this issue Jul 26, 2021
@ewbankkit
r/aws_budgets_budget: 'time_period_start' is optional (#19803).
875772d 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAWSBudgetsBudget_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSBudgetsBudget_basic -timeout 180m
=== RUN   TestAccAWSBudgetsBudget_basic
=== PAUSE TestAccAWSBudgetsBudget_basic
=== RUN   TestAccAWSBudgetsBudget_basicish
=== PAUSE TestAccAWSBudgetsBudget_basicish
=== CONT  TestAccAWSBudgetsBudget_basic
=== CONT  TestAccAWSBudgetsBudget_basicish
--- PASS: TestAccAWSBudgetsBudget_basic (17.08s)
--- PASS: TestAccAWSBudgetsBudget_basicish (27.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	30.688s
@github-actions github-actions bot added this to the v3.52.0 milestone Jul 27, 2021
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/budgets Issues and PRs that pertain to the budgets service.
Projects
None yet
Milestone
v3.52.0
2 participants
@ewbankkit @farhanangullia