Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for include filters in AWS DataSync task #20849

Closed
shuichiro-makigaki opened this issue Sep 9, 2021 · 3 comments · Fixed by #25929
Closed

Add support for include filters in AWS DataSync task #20849

shuichiro-makigaki opened this issue Sep 9, 2021 · 3 comments · Fixed by #25929
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/datasync Issues and PRs that pertain to the datasync service.

Comments

@shuichiro-makigaki
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS DataSync task supports include filters as well as exclude filters.

This enhancement enables us to have greater control over how data is transferred. Additionally, we can queue multiple executions of a task when the filter settings differ between executions.

New or Affected Resource(s)

  • aws_datasync_task

Potential Terraform Configuration

resource "aws_datasync_task" "sync_subset" {
  excludes {
    filter_type = "SIMPLE_PATTERN"
    value       = "/dir_A|/dir_B"
  }
  includes {
    filter_type = "SIMPLE_PATTERN"
    value       = "/dir_C|/dir_D"
  }
} 

References

@shuichiro-makigaki shuichiro-makigaki added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 9, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/datasync Issues and PRs that pertain to the datasync service. labels Sep 9, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 9, 2021
@swiatek25
Copy link

swiatek25 commented Feb 1, 2022

Will related PR be included for the next release?

matiu3 pushed a commit to matiu3/terraform-provider-aws that referenced this issue Jul 22, 2022
@matiu3
Copy link

matiu3 commented Jul 22, 2022

Shurichiro's PR got approved, but never got merged, and now it's in conflict. I just stole Shuichiro's code and rebased it in the above PR. I hope the tests pass.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/datasync Issues and PRs that pertain to the datasync service.
Projects
None yet
4 participants